Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Mini-Cart: aria-label value contains price even if "Display total price" attribute is set to false #9645

Closed
Tracked by #9198
Aljullu opened this issue May 30, 2023 · 0 comments · Fixed by #9672
Closed
Tracked by #9198

Mini-Cart: aria-label value contains price even if "Display total price" attribute is set to false #9645

Aljullu opened this issue May 30, 2023 · 0 comments · Fixed by #9672
Assignees
@roykho
Labels
block: mini-cart Issues related to the Mini-Cart block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 30, 2023

To reproduce

  1. Add the Mini-Cart block to a post or page and set the Display total price attribute to false.
  2. Go to the frontend and with your browser devtools (F12) instead the aria-label value.
  3. Notice it says "X items in cart, total price of Y".

Expected behavior

If Display total price attribute is set to false, I would expect aria-label to not contain the price, so it should be something like "X items in cart".
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: accessibility The issue/PR is related to accessibility. block: mini-cart Issues related to the Mini-Cart block. labels May 30, 2023
@Aljullu Aljullu mentioned this issue May 30, 2023
Closed
@roykho roykho self-assigned this May 31, 2023
@roykho roykho mentioned this issue May 31, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roykho roykho

Labels
block: mini-cart Issues related to the Mini-Cart block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure aria-label is showing correct value based on setting woocommerce/woocommerce-blocks
2 participants
@roykho @Aljullu