Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Local Pickup: WooCommerce Subscriptions should render local pickup rates in a local pickup slot #7998

Closed
senadir opened this issue Dec 20, 2022 · 3 comments · Fixed by #8636
Assignees
Labels
block: checkout Issues related to the checkout block. block-type: local pickup Issues related to local pickup. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: bug The issue/PR concerns a confirmed bug.

Comments

@senadir
Copy link
Member

senadir commented Dec 20, 2022

Right now, WooCommerce Subscriptions render its rates in the shipping options block, it mixes both pickup locations and regular rates there.

If you switch to local pickup panel, WooCommerce Subscriptions doesn't render there.

WooCommerce Subscriptions is a bit different because it doesn't add packages, it add a whole new cart so we can't merge those packages.

What we should do:

  • Introduce a new slot fill inside the local pickup one.
  • Have WooCommerce Subscriptions render local pickup rates there.
  • Remove local pickup rates from the original package.
@senadir senadir added the type: bug The issue/PR concerns a confirmed bug. label Dec 20, 2022
@mikejolley
Copy link
Member

Waiting on #8256

We'll add a slot fill and decide whether or not to help with the integration, or just document for future addition.

@ralucaStan
Copy link
Contributor

#8256 has been merged

@opr opr self-assigned this Mar 3, 2023
@opr opr added block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. labels Mar 3, 2023
@opr
Copy link
Contributor

opr commented Mar 3, 2023

I did some work in Automattic/woocommerce-subscriptions-core#399 (comment) which shows the ExperimentalOrderLocalPickupPackages in use.

@nielslange nielslange added the block-type: local pickup Issues related to local pickup. label Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. block-type: local pickup Issues related to local pickup. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants