Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Handle select from @wordpress/data-controls deprecation warning #5339

Closed
ralucaStan opened this issue Dec 8, 2021 · 1 comment · Fixed by #5574
Closed

Handle select from @wordpress/data-controls deprecation warning #5339

ralucaStan opened this issue Dec 8, 2021 · 1 comment · Fixed by #5574
Assignees
@mikejolley @nielslange
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: dependencies Pull requests that update a dependency file (used by renovate). type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ralucaStan
Copy link
Contributor

The select, syncSelect and dispatch exports from @wordpress/data-controls have been deprecated and we see this type of warnings:

["`select` control in `@wordpress/data-controls` is deprecated. Please use built-in `resolveSelect` control in `@wordpress/data` instead."]

We should fix this by switching to the corresponding controls. (For example: built-in resolveSelect control in @wordpress/data)

Things to take into consideration: see p1634809299040100-slack-C8X6Q7XQU

  • What version of WordPress is the replacement available?
  • Is the deprecated implementation in Woo Blocks in code that is exposed to users via Woo Core?
  • What version of WordPress does Woo Core still require as minimum support and does that fall in the appropriate range?
@ralucaStan ralucaStan added type: dependencies Pull requests that update a dependency file (used by renovate). type: cooldown Things that are queued for a cooldown period (assists with planning). type: wp dependency type: task The issue is an internally driven task (e.g. from another A8c team). labels Dec 8, 2021
@ralucaStan
Copy link
Contributor Author

ralucaStan commented Dec 8, 2021 •
edited
Loading

After the change some tests might be failing, like this one , so the assertion should be removed. Just search in the project for

`select` control in `@wordpress/data-controls` is deprecated. Please use built-in `resolveSelect` control in `@wordpress/data` instead.

@mikejolley mikejolley self-assigned this Jan 13, 2022
@mikejolley mikejolley mentioned this issue Jan 17, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

@nielslange nielslange

Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: dependencies Pull requests that update a dependency file (used by renovate). type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
No milestone
5 participants
@mikejolley @ralucaStan @nielslange @opr @senadir