Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Automatically insert the Mini Cart via Block Hooks #11518

Closed
sunyatasattva opened this issue Oct 31, 2023 · 4 comments
Closed

Automatically insert the Mini Cart via Block Hooks #11518

sunyatasattva opened this issue Oct 31, 2023 · 4 comments
Labels
block: mini-cart Issues related to the Mini-Cart block. type: duplicate The issue/PR is a duplicate of another issue. type: enhancement The issue is a request for an enhancement.

Comments

@sunyatasattva
Copy link
Contributor

[Block hooks] are a new feature coming in WordPress 6.4 which allow certain blocks to be inserted automatically by plugins in block themes (templates, template parts, etc.). This is an incredibly useful feature for the Mini Cart block, which is almost universally present on the header of most eCommerce sites.

#10649 implements a version of it but inserts it after every navigation block. We probably want to only insert it as the last child of the header.

@sunyatasattva sunyatasattva added type: enhancement The issue is a request for an enhancement. block: mini-cart Issues related to the Mini-Cart block. labels Oct 31, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Nov 13, 2023

Heads-up that this will be fixed in #11745.

Also, wondering if we should mark this issue as a duplicate of woocommerce/woocommerce#42385. What do you think, @sunyatasattva?

@sunyatasattva
Copy link
Contributor Author

I would have thought exploring and implementing might be worth two different issues, but in this case the other issue is still marked as open and there is more interesting discussion going on there. I agree on closing it as duplicate. What do you think of adding woocommerce/woocommerce#42385 inside the Epic, though?

@sunyatasattva sunyatasattva closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
@sunyatasattva sunyatasattva added the type: duplicate The issue/PR is a duplicate of another issue. label Nov 13, 2023
@sunyatasattva
Copy link
Contributor Author

Duplicate of woocommerce/woocommerce#42385

@Aljullu
Copy link
Contributor

Aljullu commented Nov 13, 2023

Thanks, @sunyatasattva!

I agree on closing it as duplicate. What do you think of adding woocommerce/woocommerce#42385 inside the Epic, though?

It makes sense to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. type: duplicate The issue/PR is a duplicate of another issue. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants