-
Notifications
You must be signed in to change notification settings - Fork 219
[CYS Woo Express] Large header #11390
Comments
Quick note regarding the icon size: that will be worked on by Guidorah as part of woocommerce/woocommerce#40947 : we should not be hardcoding the width of the icon in patterns. |
Unfortunately, we can't achieve the mobile view. As discussed earlier, we can only "hide" the navigation block in the mobile view. We can't:
It is worth mentioning that it is possible to hide the Search Block only if it is an inner block of the Navigation block. |
After discussing it on Slack, it looks like this is the only viable—and temporary—solution for mobile: Let me know if you have any further questions 🙏 |
I tried to implement this pattern, but the current approach doesn't work on mobile. The first row is too large. cc @verofasulo |
Thanks for trying it out, @gigitux! 🙏
I'm not sure I got the issue 😅 Can't we:
|
As I already mentioned above, on very small screens, the Mini Cart icon falls outside of the screen. For example, this is what happens on the iPhone SE: There are two fixes:
Any feedback, @verofasulo? cc @albarin |
@verofasulo thanks for the feedback, but it is the same issue: Even if I put 0px, on some devices, there is the issue: |
Adding a comment here for visibility: we decided to change the header design, both on large and narrow screens. @gigitux proposed to replicate Zalando header, and it looks really good — here's an initial video and here's the convo on Slack. @gigitux, could you please share a link to the header here once you're done so that I can have a last look? Thank you! cc @albarin |
Please review
Large header
.How it currently looks like:
How it's supposed to look like:
Figma - Large screens
Figma - Small screens
The text was updated successfully, but these errors were encountered: