Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Tabular Data: Update download button to match design documentation #442

Closed
LevinMedia opened this issue Sep 18, 2018 · 4 comments
Closed
Assignees
Labels
focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.

Comments

@LevinMedia
Copy link
Contributor

Update the download button to match the documentation per p6riRB-3lZ-p2

Currently:

screen shot 2018-09-18 at 1 10 51 pm

Design documentation:

screen shot 2018-09-18 at 1 12 17 pm

@LevinMedia LevinMedia added type: enhancement The issue is a request for an enhancement. focus: analytics Issues about Analytics/Reports needs: design The issue requires design input/work from a designer. focus: components Issues for woocommerce components labels Sep 18, 2018
@joshuatf joshuatf self-assigned this Oct 16, 2018
@joshuatf
Copy link
Contributor

It looks like the "cloud-download" icon is not currently available in dash-icons and they're considering retiring it - WordPress/gutenberg#10552 (comment)

What do you think @LevinMedia ? Should we push to add the cloud-download icon or switch to an alternative?

Here's the current download option for reference - https://cloudup.com/cH8SR8Ki8v2

@LevinMedia
Copy link
Contributor Author

Heya @joshuatf can we pull in gridicons here? http://automattic.github.io/gridicons/ The download cloud is available there too, but if that doesn't work, the icon you provided would work too.

@joshuatf
Copy link
Contributor

Heya @joshuatf can we pull in gridicons here? http://automattic.github.io/gridicons/ The download cloud is available there too, but if that doesn't work, the icon you provided would work too.

@LevinMedia The full set doesn't seem to be available in Gutenberg where we pull icons and I don't think we'll want to add another dependency. But I'm sure we can add that single SVG path manually and include it inline.

@timmyc
Copy link
Contributor

timmyc commented Oct 31, 2018

Closed by #560

@timmyc timmyc closed this as completed Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants