Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spend: bump bdk_coin_select dependency to 0.3.0 #923

Closed
jp1ac4 opened this issue Jan 15, 2024 · 3 comments · Fixed by #1076
Closed

spend: bump bdk_coin_select dependency to 0.3.0 #923

jp1ac4 opened this issue Jan 15, 2024 · 3 comments · Fixed by #1076
Assignees
@jp1ac4
Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI)
Milestone
v6 - Liana

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jan 15, 2024

This will enable us to revert the temporary fix from #867.

Note that the min change value is no longer inclusive (see bitcoindevkit/coin-select#14 (comment)) and so the min value we set in the change policy will need to be decreased by 1.
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Feb 5, 2024

We can wait until the changes relating to RBF have also been released: bitcoindevkit/coin-select#19.

@darosior darosior added the Daemon / Liana library This is about lianad or the liana library (not the GUI) label Feb 5, 2024
@darosior
Copy link
Member

They still haven't been released? Could you open a PR upstream which bumps the version in the Cargo.toml and kindly ask them to publish to crates.io?

@darosior darosior moved this to Todo in Liana v6 Mar 22, 2024
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Apr 1, 2024

v0.3.0 has now been released 🎉

@jp1ac4 jp1ac4 changed the title spend: bump bdk_coin_select dependency to 0.2.0 spend: bump bdk_coin_select dependency to 0.3.0 Apr 1, 2024
@jp1ac4 jp1ac4 moved this from Todo to In Progress in Liana v6 Apr 1, 2024
@jp1ac4 jp1ac4 mentioned this issue Apr 5, 2024
Merged
@jp1ac4 jp1ac4 moved this from In Progress to Done in Liana v6 Apr 25, 2024
@nondiremanuel nondiremanuel added this to the Liana v6 milestone Jun 25, 2024
@nondiremanuel nondiremanuel moved this to Done in Liana General Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jp1ac4 jp1ac4

Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI)
Projects
Liana General
Archived in project
Liana v6
Status: Done
Milestone
v6 - Liana
Development

Successfully merging a pull request may close this issue.

Bump bdk_coin_select to 0.3.0 jp1ac4/liana
3 participants
@darosior @nondiremanuel @jp1ac4