Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4.5.x] disabled sideMenu + iOS pop gestures #5865

Open
itsam opened this issue Jan 21, 2020 · 1 comment
Open

[V4.5.x] disabled sideMenu + iOS pop gestures #5865

itsam opened this issue Jan 21, 2020 · 1 comment

Comments

@itsam
Copy link
Contributor

itsam commented Jan 21, 2020

Issue Description

#3651 still exists

Steps to Reproduce / Code Snippets / Screenshots

  1. Create a stack layout nested inside of a sideMenu layout (with left and center components)
  2. Push a new screen onto the stack while simultaneously disabling the left side menu.
  3. Attempt to swipe right in order to pop the new screen from the stack and go back. Note that it's difficult to pop the screen.

Environment

  • React Native Navigation version: 4.5.3-snapshot.717
  • React Native version: 0.61.5
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): iPhone 7 13.2.3
@itsam
Copy link
Contributor Author

itsam commented Jan 22, 2020

I fixed it... :) everything works smooth now!

https://gist.github.com/itsam/f33a063bf5f07ef7b4112e691f7edddc
Don't know how to get the defined openGestureMode (e.g. 'bezel') though...
In any case, someone (@guyca maybe) who knows how to complete this, please make a PR.

This feature should be definitely merged in master.
Thanks

itsam referenced this issue Jan 22, 2020
* Fix popGesture freeze the app

* Move popGestureDelegate initialization to init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants