From 34b1f8429192624ad28ab83a531d8bdba4c45494 Mon Sep 17 00:00:00 2001 From: Tyler van der Hoeven Date: Thu, 28 Mar 2024 22:32:04 -0400 Subject: [PATCH 1/3] remove the ssr external for vue --- packages/integrations/vue/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/integrations/vue/src/index.ts b/packages/integrations/vue/src/index.ts index 62ca0946c707..df756ebe81d1 100644 --- a/packages/integrations/vue/src/index.ts +++ b/packages/integrations/vue/src/index.ts @@ -116,7 +116,7 @@ async function getViteConfiguration(options?: Options): Promise { }, plugins: [vue(vueOptions), virtualAppEntrypoint(vueOptions)], ssr: { - external: ['@vue/server-renderer'], + // external: ['@vue/server-renderer'], noExternal: ['vuetify', 'vueperslides', 'primevue'], }, }; From 99c8fece9870d4c84e4cbba3de025274007438e2 Mon Sep 17 00:00:00 2001 From: Tyler van der Hoeven Date: Fri, 29 Mar 2024 09:01:42 -0400 Subject: [PATCH 2/3] Remove the external line vs comment it out --- packages/integrations/vue/src/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/integrations/vue/src/index.ts b/packages/integrations/vue/src/index.ts index df756ebe81d1..6f451c42451d 100644 --- a/packages/integrations/vue/src/index.ts +++ b/packages/integrations/vue/src/index.ts @@ -116,7 +116,6 @@ async function getViteConfiguration(options?: Options): Promise { }, plugins: [vue(vueOptions), virtualAppEntrypoint(vueOptions)], ssr: { - // external: ['@vue/server-renderer'], noExternal: ['vuetify', 'vueperslides', 'primevue'], }, }; From 248b1eae1f8cac57d2125b4c6d649da2191573ba Mon Sep 17 00:00:00 2001 From: Tyler van der Hoeven Date: Fri, 29 Mar 2024 12:02:08 -0400 Subject: [PATCH 3/3] add a changeset --- .changeset/gold-lies-behave.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/gold-lies-behave.md diff --git a/.changeset/gold-lies-behave.md b/.changeset/gold-lies-behave.md new file mode 100644 index 000000000000..bd2bf1c491c8 --- /dev/null +++ b/.changeset/gold-lies-behave.md @@ -0,0 +1,5 @@ +--- +"@astrojs/vue": patch +--- + +Remove the unnecessary and deprecated @vue/server-renderer package from the ssr.external vite config