Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 4.0.4+ leaves manifest_HASH.mjs file behind in the build ouput folder #9450

Closed
1 task
kireerik opened this issue Dec 17, 2023 · 3 comments · Fixed by #9475
Closed
1 task

version 4.0.4+ leaves manifest_HASH.mjs file behind in the build ouput folder #9450

kireerik opened this issue Dec 17, 2023 · 3 comments · Fixed by #9475
Assignees
@ematipico
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: astro Related to the core `astro` package (scope)

Comments

@kireerik
Copy link

kireerik commented Dec 17, 2023 •
edited
Loading

Astro Info

Astro                    v4.0.4
Node                     v21.4.0
System                   Windows (x64)
Package Manager          pnpm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

See the title.

What's the expected result?

Works the same as before version 4.0.4.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-4ckdit (created by @vedxp)

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 17, 2023
@jacobdalamb
Copy link
Contributor

Please reproduce the issue.

@florian-lefebvre florian-lefebvre added the needs repro Issue needs a reproduction label Dec 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hello @kireerik. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Dec 17, 2023
@vedxp
Copy link

vedxp commented Dec 18, 2023

Please reproduce the issue.

Here's a minimal reproduction on StackBlitz:
https://stackblitz.com/edit/github-4ckdit?file=dist%2Fmanifest_CxEKb7vn.mjs

@ematipico ematipico removed the needs repro Issue needs a reproduction label Dec 19, 2023
@ematipico ematipico self-assigned this Dec 19, 2023
@ematipico ematipico added - P4: important Violate documented behavior or significantly impacts performance (priority) pkg: astro Related to the core `astro` package (scope) labels Dec 19, 2023
@ematipico ematipico mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ematipico ematipico

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove the manifest file from the dist/ folder withastro/astro
5 participants
@ematipico @kireerik @jacobdalamb @florian-lefebvre @vedxp