From b6797fc8583f7cb0749e69e72a56fe9fba6f815b Mon Sep 17 00:00:00 2001
From: Matthew Phillips <matthew@skypack.dev>
Date: Tue, 2 May 2023 13:23:28 -0400
Subject: [PATCH] =?UTF-8?q?Update=20Solid=20ecosystem=20package=20logic=20?=
 =?UTF-8?q?to=20include=20packages=20with=20peerDep=E2=80=A6=20(#6934)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Update Solid ecosystem package logic to include packages with peerDep of Solid

* Remove solid as a noExternal

* Update the changeset
---
 .changeset/purple-lamps-sleep.md         | 5 +++++
 packages/integrations/solid/src/index.ts | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/purple-lamps-sleep.md

diff --git a/.changeset/purple-lamps-sleep.md b/.changeset/purple-lamps-sleep.md
new file mode 100644
index 000000000000..9dd063e6aa73
--- /dev/null
+++ b/.changeset/purple-lamps-sleep.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/solid-js": patch
+---
+
+Allow Solid ecosystem packages to not need special export map configuration. By default Solid is now treated as an external package in SSR, so any other dependent packages will receive the same instance.
diff --git a/packages/integrations/solid/src/index.ts b/packages/integrations/solid/src/index.ts
index edf58fdeae16..8ec9f4d8d0d6 100644
--- a/packages/integrations/solid/src/index.ts
+++ b/packages/integrations/solid/src/index.ts
@@ -47,7 +47,7 @@ async function getViteConfiguration(isDev: boolean, astroConfig: AstroConfig) {
 		ssr: {
 			target: 'node',
 			external: ['babel-preset-solid', ...solidPkgsConfig.ssr.external],
-			noExternal: ['solid-js', ...solidPkgsConfig.ssr.noExternal],
+			noExternal: [...solidPkgsConfig.ssr.noExternal],
 		},
 	};
 }