fix: Catch and suppress buffer errors inside transaction (WPB-16234) #6959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
przemvs
approved these changes
Feb 24, 2025
aweiss-dev
approved these changes
Feb 24, 2025
V-Gira
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we receive out of order messages core crypto buffers them and throws one of these errors:
BufferedFutureMessage
Other("Incoming message is a commit for which we have not yet received all the proposals. Buffering until all proposals have arrived.")
Currently if you use the non-transactional API this means buffered messages will never be persisted since the underlying transaction is always cancelled when errors bubble up.
Solution
When decrypting messages use the transactional API and catch the buffer errors inside the transaction to avoid the transaction being cancelled since we actually want the changes, buffered messages, to be persisted.