Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong on split #20

Open
DatL4g opened this issue Mar 12, 2023 · 3 comments
Open

Something is wrong on split #20

DatL4g opened this issue Mar 12, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@DatL4g
Copy link

DatL4g commented Mar 12, 2023

I currently switched from https://github.com/marketplace/actions/simple-split and something is off.

I'm using another action to sign a list of files.
This will produce a string of the full path to the signed files, separated by a :.

The signing output string looks like this:
/home/runner/work/Burning-Series/Burning-Series/app/release/app-release-signed.aab:/home/runner/work/Burning-Series/Burning-Series/app/release/app-release-signed.apk

My split config looks like this:

- name: Split signed files
  uses: JungWinter/split@v2.1.0
  id: split
  with:
    msg: ${{ steps.sign_app.outputs.signedFiles }}
    separator: ':'
    maxsplit: 2

When I try to upload the files by their split path it can't find the first file.

So it tries to resolve /github/workspace/app/release/app-release-signed.aab but can't find it

However it works with the second file

You can take a look at the job here: https://github.com/DATL4G/Burning-Series/actions/runs/4398432795/jobs/7702280605

@winterjung
Copy link
Owner

Thank you for letting me know about the issue. It seems that there was an unexpected change in the workspace path mapping after the sign_app step. I'm guessing the split actions is docker-based, so it was affected. (refs. actions/runner#763, actions/runner#1009, actions/runner#2058)

image

Upon checking the job log, I also found that /home/runner/work/Burning-Series/Burning-Series/app/release/app-release-signed.aab:/home/runner/work/Burning-Series/Burning-Series/app/release/app-release-signed.apk was passed into the split action, but it unintentionally became /github/workspace/app/release/app-release-signed.aab during the process.

To help with debugging, I created a new version of the split@v2.1.1-rc1, which you can try using by adding uses: JungWinter/split@v2.1.1-rc1 to your workflow. However, I'm not sure if this version can be used without marketplace publishing. If you encounter any issues, please let me know.

@winterjung winterjung added the bug Something isn't working label Mar 13, 2023
@supersu-man
Copy link

I am facing the exact same issue.
This
/home/runner/work/nerd-clocksas/nerd-clocksas/app/build/outputs/app-release-signed.aab:/home/runner/work/nerd-clocksas/nerd-clocksas/app/build/outputs/app-release-signed.apk
is being split into these
/github/workspace/app/build/outputs/app-release-signed.aab
/home/runner/work/nerd-clocksas/nerd-clocksas/app/build/outputs/app-release-signed.apk

@winterjung It does not work with uses: JungWinter/split@v2.1.1-rc1 nor does it throw an error.

@winterjung
Copy link
Owner

@supersu-man sorry for late replying. Could you try with uses: winterjung/split@v2.1.1-rc1 and share the debugging log? I renamed account name recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants