Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up unit tests with WIRC #38

Closed
robertdstein opened this issue Jul 20, 2022 · 2 comments · Fixed by #54
Closed

Set up unit tests with WIRC #38

robertdstein opened this issue Jul 20, 2022 · 2 comments · Fixed by #54
Assignees
@robertdstein @virajkaram
Labels
enhancement New feature or request tests Related to unit tests

Comments

@robertdstein
Copy link
Member

We got the green light for setting up unit tests with WIRC data. This would involve making a minimum number of WIRC images public, needed for testing the pipeline. We should identify which images are needed:

  • A target where we have an image to use as a reference for subtraction
  • A set of flats/darks
  • A block of dithers for a WIRC stack
  • Ideally use published data -> Select old target
@robertdstein robertdstein added enhancement New feature or request tests Related to unit tests labels Jul 20, 2022
@robertdstein robertdstein self-assigned this Jul 20, 2022
@robertdstein
Copy link
Member Author

Linked to/prerequisite for #22

@robertdstein
Copy link
Member Author

@virajkaram will provide a suitable source

@robertdstein robertdstein mentioned this issue Aug 1, 2022
Closed
@robertdstein robertdstein linked a pull request Aug 2, 2022 that will close this issue
Wirctest #54
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertdstein robertdstein

@virajkaram virajkaram

Labels
enhancement New feature or request tests Related to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wirctest winter-telescope/mirar
2 participants
@robertdstein @virajkaram