Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete observing log #119

Closed
virajkaram opened this issue Sep 1, 2022 · 2 comments · Fixed by #132
Closed

Incomplete observing log #119

virajkaram opened this issue Sep 1, 2022 · 2 comments · Fixed by #132
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@virajkaram
Copy link
Collaborator

At the end of real-time running of pipeline, the observing csv log has only one science frame and all calibration frames. Presumably, it gets overwritten every time pipeline is run

@robertdstein
Copy link
Member

I was thinking about this today. It will take a bit of work to get it right. First step would be to move the CSV log step to "load raw image" block. That prevents the repeated/useless overwriting. The more complicated thing is working out how to make the log properly. My personal idea would be to let the monitor execute a separate "finish up" block after n hours, which would be in charge of making the log and other such tasks like calculating quality.

@robertdstein robertdstein added bug Something isn't working enhancement New feature or request labels Sep 1, 2022
@robertdstein
Copy link
Member

robertdstein commented Sep 1, 2022

In principal we could just reprocess the entire night on the spot at that time, using the calibration images from that night. Right now the monitor is not smart enough to work out that when new calibration images come in, it should stop using the ones from yesterday.

@robertdstein robertdstein self-assigned this Sep 2, 2022
@robertdstein robertdstein linked a pull request Sep 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants