From ac23f41afcfada2dc60121f53067b2b86abaa4dc Mon Sep 17 00:00:00 2001 From: Roman Gilg Date: Sat, 8 Apr 2023 23:11:18 +0200 Subject: [PATCH] fix(client): set correct parent of output configuration Setting the manager as parent of a configuration is unexpected and unsafe. Instead set the provided parent if any. --- src/client/wlr_output_manager_v1.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/client/wlr_output_manager_v1.cpp b/src/client/wlr_output_manager_v1.cpp index 4648cad0..5ddf887b 100644 --- a/src/client/wlr_output_manager_v1.cpp +++ b/src/client/wlr_output_manager_v1.cpp @@ -150,8 +150,7 @@ bool WlrOutputManagerV1::isValid() const WlrOutputConfigurationV1* WlrOutputManagerV1::createConfiguration(QObject* parent) { - Q_UNUSED(parent); - auto* config = new WlrOutputConfigurationV1(this); + auto config = new WlrOutputConfigurationV1(parent); auto w = zwlr_output_manager_v1_create_configuration(d->outputManager, d->serial); if (d->queue) {