From 6f292324fd98647abc33ed59a691cec38a8b7827 Mon Sep 17 00:00:00 2001 From: Kurru Date: Tue, 26 Jul 2022 12:17:34 -0700 Subject: [PATCH] Improve emitter send data log (#343) * Improve the emitter sendData failure log message to include the number of bytes involved and the type of entity that failed to be published. New log message has format: Exception while sending segment (SegmentImpl) over UDP for entity CoreApi [1827010d1fe3a482] on segment [no parent segment]. Bytes: 77861 * Improve the emitter sendData failure log message to include the number of bytes involved and the type of entity that failed to be published. New log message has format: Exception while sending segment (SegmentImpl) over UDP for entity CoreApi [1827010d1fe3a482] on segment [no parent segment]. Bytes: 77861 --- .../src/main/java/com/amazonaws/xray/emitters/UDPEmitter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/emitters/UDPEmitter.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/emitters/UDPEmitter.java index fb8ee391..542411fc 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/emitters/UDPEmitter.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/emitters/UDPEmitter.java @@ -116,8 +116,8 @@ private boolean sendData(byte[] data, Entity entity) { daemonSocket.send(packet); } catch (Exception e) { String segmentName = Optional.ofNullable(entity.getParent()).map(this::nameAndId).orElse("[no parent segment]"); - logger.error("Exception while sending segment over UDP for entity " + nameAndId(entity) + " on segment " - + segmentName, e); + logger.error("Exception while sending segment (" + entity.getClass().getSimpleName() + ") over UDP for entity " + + nameAndId(entity) + " on segment " + segmentName + ". Bytes: " + data.length, e); return false; } return true;