Skip to content

Commit

Permalink
Enable PhanPluginDuplicateExpressionAssignmentOperation issue
Browse files Browse the repository at this point in the history
Conflicts between backports before the EOL of 1.35 and
a release of this config enabled as default seems very unlikly.

Change-Id: I10c558b114616eca1097fcb0be52b4bc6b57453a
  • Loading branch information
umherirrender committed Oct 13, 2023
1 parent a091c4d commit 5875745
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
8 changes: 1 addition & 7 deletions src/config-library.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,7 @@
// Would probably have many false positives
'PhanPluginMixedKeyNoKey',
] )
->enableTaintCheck( $DIR, 'vendor/' )
->suppressIssueTypes(
// PHP 7.4 functionality; suppress by default until we no longer support PHP < 7.4.
// In reality, this means when MW 1.35 is EOL, expected September 2023.
// This will hopefully prevent some issues with backporting.
'PhanPluginDuplicateExpressionAssignmentOperation',
);
->enableTaintCheck( $DIR, 'vendor/' );

// BC: We're not ready to use the ConfigBuilder everywhere
return $baseCfg->make();
8 changes: 1 addition & 7 deletions src/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,7 @@
'wgRequest' => file_exists( "$IP/includes/Request/WebRequest.php" )
? '\\MediaWiki\\Request\\WebRequest' : '\\WebRequest',
] )
->enableTaintCheck( $DIR, $VP )
->suppressIssueTypes(
// PHP 7.4 functionality; suppress by default until we no longer support PHP < 7.4.
// In reality, this means when MW 1.35 is EOL, expected September 2023.
// This will hopefully prevent some issues with backporting.
'PhanPluginDuplicateExpressionAssignmentOperation',
);
->enableTaintCheck( $DIR, $VP );

// BC: We're not ready to use the ConfigBuilder everywhere
return $baseCfg->make();

0 comments on commit 5875745

Please sign in to comment.