unexpected token kDO for Ruby 2.3

[bdewater]

Similar to reports #466, #447 and #507

We want to add Rubocop to ActiveMerchant: activemerchant/active_merchant#2894 but right now we need to exclude a few files since they break.

lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb breaks:

lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:384:29: E: Lint/Syntax: unexpected token kDO_BLOCK
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
            recipients.each do |money, recipient, options|
                            ^^
lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:384:58: E: Lint/Syntax: unexpected token tPIPE
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
            recipients.each do |money, recipient, options|
                                                         ^
lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:386:39: E: Lint/Syntax: unexpected token kDO_BLOCK
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
              xml.tag!('MassPayItem') do
                                      ^^
lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:716:3: E: Lint/Syntax: unexpected token kEND
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
  end
  ^^^

and lib/active_merchant/billing/gateways/paypal_express.rb:

lib/active_merchant/billing/gateways/paypal_express.rb:175:49: E: Lint/Syntax: unexpected token kDO_BLOCK
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
                options[:shipping_options].each do |shipping_option|
                                                ^^
lib/active_merchant/billing/gateways/paypal_express.rb:176:28: E: Lint/Syntax: unexpected token tSTRING
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
                  xml.tag! 'n2:FlatRateShippingOptions' do
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/active_merchant/billing/gateways/paypal_express.rb:266:3: E: Lint/Syntax: unexpected token kEND
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
  end
  ^^^

Switching the TargetRubyVersion setting to 2.4 makes the problem go away. This is with parser 2.5.1.0.

cc @bpollack

[iliabylich]

I can't reproduce it using the latest mater. @whitequark could you cut a release please? There are a few unreleased changes, one of them is related to cmdarg logic.

[whitequark]

Ah, will do soon.

[whitequark]

2.5.1.1, sorry for the delay.