Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and reuse TOC #538

Open
Forage opened this issue May 17, 2021 · 4 comments
Open

Store and reuse TOC #538

Forage opened this issue May 17, 2021 · 4 comments
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions

Comments

@Forage
Copy link
Contributor

Forage commented May 17, 2021

It can take some time for whipper cd info to finish reading the TOC. When starting whipper cd rip the same process is repeated. Providing a way to store the TOC when using info and reusing the same when following up with a rip would speed up the process a bit.

While it being just a rough idea, several things come to mind:

  • Allow providing a parameter for a file name for info and rip to subsequently save the TOC and read the TOC from
  • Maybe even store the TOC as a cached file and automatically reuse it when available
  • In case of the latter as default behaviour a parameter to disable TOC caching might be useful
  • Add a check for e.g. disc ID when reusing a TOC file to make sure there's no mismatch

In addition to a speed-up for when you happen to use info before rip, it would also function as groundwork for a possible Whipper GUI in the future. You'd want to systematically view the disc content before ripping.

@Forage
Copy link
Contributor Author

Forage commented May 18, 2021

I see now (#335) that you're actually doing the opposite at the moment by removing the caching, the only difference being that the TOC was stored during the rip process instead of info.

Does this make the use-case described above a no go?

@JoeLametta JoeLametta added Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions labels May 20, 2021
@JoeLametta
Copy link
Collaborator

@Freso, @MerlijnWajer what's your opinion about this?

@Forage
Copy link
Contributor Author

Forage commented May 21, 2021

An alternative would be to have a 'light' version of info not doing an extensive analysis but sticking to basic disc and track info like number, length, ISRC, title, MB additions, etc.

@MerlijnWajer
Copy link
Collaborator

Sorry for the late response, but yeah, I'd argue in favour of removing the cache rather than caching more. Yes, it's annoying that it sometimes reads the entire CD again to get an accurate toc, but a (wrong) cache can be much more annoying, at least in my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions
Projects
None yet
Development

No branches or pull requests

3 participants