Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs.agda-version is empty #183

Closed
andreasabel opened this issue May 27, 2023 · 3 comments
Closed

outputs.agda-version is empty #183

andreasabel opened this issue May 27, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@andreasabel
Copy link

With workflow steps like this:

env:
  AGDA_VERSION: 2.6.3
  STDLIB_VERSION: 1.7.1
...
      - name: Setup Agda
        uses: wenkokke/setup-agda@latest
        id:   setup
        with:
          agda-version: ${{ env.AGDA_VERSION }}
          agda-stdlib-version: ${{ env.STDLIB_VERSION }}

      - name: Cache build
        uses: actions/cache@v3
        id:   cache
        with:
          key: agda-${{ steps.setup.outputs.agda-version }}-stdlib-${{ env.STDLIB_VERSION }}

I get an empty steps.setup.outputs.agda-version, as witnessed in this workflow run:
https://github.com/graded-type-theory/graded-type-theory/actions/runs/5093788246/jobs/9156820105#step:4:3

Run actions/cache@v3
  with:
    key: agda--stdlib-1.7.1

I am using latest (2023-02-07).

@wenkokke wenkokke added the bug Something isn't working label May 27, 2023
@wenkokke
Copy link
Owner

Oh, I think it's only actually setting agda-path and agda-data-path!

@andreasabel
Copy link
Author

But the intention is that it sets all of these, or?

setup-agda/action.yml

Lines 212 to 224 in abaf527

outputs:
agda-version:
description: 'The resolved Agda version.'
agda-path:
description: 'The path of the agda executable _directory_.'
agda-data-path:
description: 'The path of the agda data _directory_.'
agda-exe:
description: 'The path of the agda _executable_.'
agda-mode-exe:
description: 'The path of the agda-mode _executable_.'
setup-haskell:
description: 'Whether or not actions/haskell/setup was called.'

I guess actionlint learns from this list; it didn't alert me of an unknown output agda-version or so.

@wenkokke
Copy link
Owner

It's definitely the intention that these are set, otherwise it's quite difficult to figure what version you've installed when using "latest" or "recommended", so this is a bug that likely stuck in in v2.0.0 after I decoupled the Agda installation from the action itself.

Thanks for the pointer to actionlint, I'll plan to incorporate that into the test suite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants