Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify works on android #1

Closed
saulshanabrook opened this issue Jul 15, 2016 · 6 comments
Closed

Verify works on android #1

saulshanabrook opened this issue Jul 15, 2016 · 6 comments

Comments

@saulshanabrook
Copy link
Member

update facebook/react-native#1424 when finished

@nadinelyab
Copy link

Hi @LinusU,
I'd like to use this library and I'm wondering if there are any plans to support Android soon.
Thanks

@LinusU
Copy link
Collaborator

LinusU commented Aug 15, 2018

Hey,

I recently got this merged facebook/react-native#20366 into React Native. That should be a part of the 0.57 release which should be out very soon. With that in, we should be able to switch to the built-in WebView, which should work for both iOS and Android.

There is also a problem with accessing crypto.subtle on the about:blank page on Android. A workaround is to include a blank.html file inside the resources folder. Need to look in a bit more into that...

@nadinelyab
Copy link

Awesome! Thanks for working on this project. I will try to work on the about:blank page bug as well and submit a PR if I get anywhere with it.

@LinusU
Copy link
Collaborator

LinusU commented Aug 16, 2018

Awesome, that would be great!

@nadinelyab
Copy link

@LinusU it doesn't look like your PR made it into 0.57.0-rc.0, but maybe if you request that it be cherry picked in this discussion it will be?

@sirpy
Copy link
Collaborator

sirpy commented Feb 12, 2020

fixed

@sirpy sirpy closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants