Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it discover seeds continuasly? #9

Closed
jaruba opened this issue Dec 29, 2015 · 3 comments
Closed

Does it discover seeds continuasly? #9

jaruba opened this issue Dec 29, 2015 · 3 comments

Comments

@jaruba
Copy link

jaruba commented Dec 29, 2015

Hey, I saw you switched peer-discovery.js with this module in torrent-stream.

I had a fork of torrent-stream that used a method for a not-so-common occurrence in which a poorly seeded torrent gets all the seeds blacklisted by peer-wire-swarm for various reasons until none are left.

The only solution I found for this was to create a method that forces reconnecting to all known peers and also restarts the peer discovery in peer-discovery.js. Restarting peer discovery was important too as from various tests it proved that peer-discovery.js stopped searching for new peers for some reason, and in poorly seeded torrents and new torrents (in which seeds may be few but their numbers increase fast), rediscovery of peers is a must.

I'm curious if restarting peer discovery would still be needed with torrent-discovery or not.

@feross
Copy link
Member

feross commented Jan 2, 2016

If it was required before, I would guess that it's still required now. The code in torrent-discovery is largely the same as what was in peer-discovery.js.

@feross
Copy link
Member

feross commented Jan 2, 2016

This sounds like functionality that should be integrated into torrent-stream and webtorrent directly. If there are not enough peers, try contacting the tracker and DHT once more. Can you open a new issue on the respective issue trackers?

@feross feross closed this as completed Jan 2, 2016
@jaruba
Copy link
Author

jaruba commented Jan 2, 2016

I can't be sure if webtorrenthas the same issues as I haven't used it yet and proving this requires finding the right torrent and a lot of testing. But for torrent-stream there are PRs gathering dust for this for a long time already:

mafintosh/torrent-stream#117
mafintosh/peer-wire-swarm#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants