-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code-splitting guide missing commonly sought after answers. #1366
Comments
atleast reference https://webpack.js.org/plugins/commons-chunk-plugin/#passing-the-minchunks-property-a-function in a prominent title that leads to that example. |
@rafde I've gone ahead and noted that this is a commonly used feature of code splitting and reference the Explicit vendor chunk explaining how to do this. @skipjack I noticed a next steps section mentioning lazy-loading and caching. should there be a more robust optimization guide if there isn't one? |
I understand your frustration and I see that you were one of the authors of Here are a few reasons why the changes were made:
I think if you really think about it and see my comments above, you'll realize these comments are a bit overboard. I'll review @rouzbeh84's PR now to see if we can get a short-term fix in and note it in #1258 so we don't forget to address it. Again, as I said on gitter, please be a little more thoughtful in your approach. Just because your use case is splitting out vendor code, doesn't mean code splitting can't be used for a variety of other things. Anything missing from the caching guide now should be filled in soon -- if you want, I can even ping you for a review once it's in progress. As for "the plan" you mentioned on gitter -- please see #1380. This is something we've discussed offline for awhile now but didn't have time to add until tonight. |
Bringing in the gitter discussions has no context. That's why I made this issue, so I am going to focus why I made this issue. One of the things I noticed people complain about webpack is about documentation. So when I saw the changes I thought to myself: There goes one of the most looked at webpack question on stackoverflow. Anyhow, do what you gotta do. I stopped directing people to the doc site and use @bebraw 's guide for anything extra that I want to start getting into regarding webpack. He does a better job with guides since it's his 🍞 and butter. ☮️ and 🍀 Self closing this discussion. |
I was looking for the vendor common chunk example to reference and noticed that a lot of useful information was removed in 15f8155#diff-97b9e4722b09b5046bf7756c344112cdL19
I can't find any examples or reference to where it was moved.
Can that commit be reverted, as it offers nothing that people are actually looking for when visited.
The text was updated successfully, but these errors were encountered: