Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required git? #318

Closed
sam-s4s opened this issue Mar 7, 2018 · 5 comments
Closed

Required git? #318

sam-s4s opened this issue Mar 7, 2018 · 5 comments

Comments

@sam-s4s
Copy link

sam-s4s commented Mar 7, 2018

I'm very confused right now.

Firstly - all I need to do is provide a path to webpack... webpack --config demo/webpack.config.js. So it seems very silly that in order to do that I need to install a whole other package for webpack.

Secondly - I can't even install webpack-cli, because it requires git to be installed on my machine (and all of my company's other dev boxed and build boxes, which is not possible).

a) why does webpack-cli require git to be installed at all? This seems like a very bad decision. We have a large pipeline, and no other packages require git to be installed - including webpack itself.

b) the fact that it requires git to be installed is not mentioned anywhere - until npm install throws an error. If this project has such a strange requirement, it should be mentioned in bold text right at the top of the documentation.

Any help or explanations would be greatly appreciated. Thanks!

@itsMapleLeaf
Copy link
Contributor

It looks like one of the dependencies is a local fork from git. If we can, would we be able to resolve the issue after removing this, @ev1stensberg ?

@evenstensberg
Copy link
Member

Removing it this week

@sam-s4s
Copy link
Author

sam-s4s commented Mar 8, 2018

Ah that would be great :D

Thanks for checking that!

Also just a quick query... the current docs say...

The latest webpack release is: 4.1.1

To install the latest release or a specific version, run one of the following commands:

npm install --save-dev webpack

...

"scripts": {
    "start": "webpack --config webpack.config.js"
}

But this will not work, right, because it will also need webpack-cli ?

@ematipico
Copy link
Contributor

ematipico commented Mar 8, 2018

Yeah exactly, you need webpack-cli package installed. Although as you mentioned we have a problem with one of our dependencies where they cannot be installed via proxy. We are working on a fix. The issue can be tracked here #161

@evenstensberg
Copy link
Member

#323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants