Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interface type definition to hint about interface implementors #40

Closed
vladar opened this issue May 25, 2016 · 1 comment
Closed

Comments

@vladar
Copy link
Member

vladar commented May 25, 2016

Now when interface implementor is not referenced anywhere in schema it remains invisible for GraphQL during validation phase.

As a workaround we allow types option on Schema to pass such implementors directly. But a better way for this could be adding implementors option to interface type definition that could act as a hint for schema.

This option will accept an array or thunk of types (similar to fields and interfaces options on ObjectType).

This mechanism will have advantages over current types option on Schema only when type definitions are initialized on demand (vs collected during schema creation as it is done now).

See #38 for more info

@vladar
Copy link
Member Author

vladar commented Dec 9, 2016

After more thinking: this is bad idea. Looking for better ways to solve original issue.

@vladar vladar closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant