PWA rules

[poshaughnessy]

I thought I'd create an issue to discuss PWA rules, overall?

A first question please: currently, the online scanner groups some rules (apple-touch-icon, manifest-file-extension, ...?) under a "PWA" section, but the CLI doesn't? Is the idea to have an explicit PWA category going forwards?

It would be good if we were able to cover our Samsung Internet 'ambient badging' rules, either with custom rules or hopefully if you agree, built-in ones?

Taking a quick look at each one:

• "The site is served over HTTPS"
  New rule required? I've seen the rules for 'strict-transport-security' headers and HTTP redirects, but not simply whether the page is served over HTTPS?

• "The site registers a Service Worker"
  New rule required - Add rule to check if a service worker was registered #464?

• "The site registers a Web App Manifest"
  Covered by existing rule ("Manifest not specified").

• "The Web App Manifest has name or short_name"
  New rule required - Add rule(s) to check the usage of the Web App Manifest file #32?

• "The Web App Manifest has an icon where size is at least 144x144"
  New rule required - Add rule to check the usage of web app manifest's icons #462?

• "The Web App Manifest has display set to 'standalone' or 'fullscreen'"
  New rule required - Add rule(s) to check the usage of the Web App Manifest file #32?

How about other rules? (This is of course somewhat dependent on our PWA definition... Microsoft's slide here includes: Progressive, Responsive, Network Independent, App-Like, Fresh, Safe, Discoverable, Re-engageable, Installable, Linkable. And here is Google's checklist. I have some thoughts on this myself too).

Here are a couple more that I think might be suitable?:

• Responsive design / mobile friendly
• Service Worker caching (test that the site should function offline)

[alrra]

Is the idea to have an explicit PWA category going forwards?

We could have a formatter do that.

@sonarwhal/core ?

Also, related to this, we were thinking about having rule groups (see: #51). The idea being that users that want all the PWA rules for example, could simply include something in the lines of: "pwas": "error" and get all those rules.

---

It would be good if we were able to cover our Samsung Internet 'ambient badging' rules, either with custom rules or hopefully if you agree, built-in ones?

Personally, I think we should cover as much as possible related to PWAs with build-in/core rules.

"The site is served over HTTPS"
New rule required? I've seen the rules for 'strict-transport-security' headers and HTTP redirects, but not simply whether the page is served over HTTPS?

That should be a new rule.

How about other rules?
Here are a couple more that I think might be suitable?:

Can you open individual issues for each new rule you think we should have, and write a short description on what you think sonarwhal should test for, use cases, etc? Thanks!

[alrra]

Taking a quick look at each one:

In addition to those we are also planing on having a web app manifest parser integrated, which will make all the field related rules very simple to implement.

[alrra]

Is the idea to have an explicit PWA category going forwards?

Update: sonarwhal now supports the concept of configurations (e.g.: configuration-web-recommended), so that should take care of grouping things together.