Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikos/fix ens event test #5880

Merged
merged 17 commits into from
Mar 1, 2023
Merged

Nikos/fix ens event test #5880

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
85c345c
Expose registry events in ens class
nikoulai Feb 20, 2023
e557e55
Add tests for events
nikoulai Feb 20, 2023
0af43dc
Check for socket
nikoulai Feb 20, 2023
0a323e8
Skip test
nikoulai Feb 20, 2023
459db48
Merge branch '4.x' into nikos/4898/ens-system-tests
jdevcs Feb 22, 2023
16e6b73
Merge branch '4.x' into nikos/4898/ens-system-tests
nikoulai Feb 23, 2023
eb4daec
Try to unskip test
nikoulai Feb 24, 2023
8ab5264
Merge branch 'nikos/4898/ens-system-tests' of https://github.com/web3…
nikoulai Feb 24, 2023
e53fa49
skip test again
nikoulai Feb 24, 2023
4be99cf
Update packages/web3-eth-ens/test/integration/ens.events.test.ts
nikoulai Feb 24, 2023
7a50032
Merge branch '4.x' into nikos/4898/ens-system-tests
nikoulai Feb 28, 2023
ff1f3e2
feedback
nikoulai Feb 28, 2023
2293e5d
Try fix
nikoulai Feb 28, 2023
1f2fbe5
Merge branch '4.x'
nikoulai Feb 28, 2023
c5c0e81
Merge branch '4.x' into nikos/fix-ens-event-test
nikoulai Feb 28, 2023
04d2c09
Revert conf files
nikoulai Feb 28, 2023
1cb087d
Remove error for event
nikoulai Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/web3-eth-ens/test/integration/ens.events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ describeIf(isSocket)('ens events', () => {
});
});

// eslint-disable-next-line jest/expect-expect, jest/no-done-callback
test('NewTTL event', async () => {
// eslint-disable-next-line jest/expect-expect, jest/no-done-callback, jest/consistent-test-it
it('NewTTL event', async () => {
// eslint-disable-next-line @typescript-eslint/no-misused-promises, no-async-promise-executor
await new Promise<void>(async resolve => {
const event = ens.events.NewTTL();
Expand All @@ -186,16 +186,19 @@ describeIf(isSocket)('ens events', () => {
it('NewResolver event', async () => {
// eslint-disable-next-line @typescript-eslint/no-misused-promises, no-async-promise-executor
await new Promise<void>(async resolve => {
const mockAddress = '0x0000000000000000000000000000000000000000';
const ENS_NAME = 'web3js.eth';
const event = ens.events.NewResolver();

// eslint-disable-next-line @typescript-eslint/no-unsafe-call
event.on('data', () => {
resolve();
});

await ens.setResolver(ENS_NAME, mockAddress, sendOptions);
await ens.setResolver(
domain,
resolver.options.address as string,
sendOptions,
DEFAULT_RETURN_FORMAT,
);
});
});
});