Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start incrementing jsonrpc message id from random number #5371

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Start incrementing jsonrpc message id from random number #5371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eae2c1a
start incrementing jsonrpc.id from random number
Muhammad-Altabba Aug 22, 2022
e766254
modify the starging value of Jsonrpc message id
Muhammad-Altabba Aug 22, 2022
4a8ae6d
modify a comment at jsonrpc.js
Muhammad-Altabba Aug 22, 2022
7d83e6b
enhance calculating Jsonrpc message id
Muhammad-Altabba Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,3 +592,4 @@ Released with 1.0.0-beta.37 code base.

### Fixed
- Browser builds support polyfills (#5031) (#5053) (#4659) (#4767)
- Start incrementing jsonrpc.id from random number (#5327)
14 changes: 11 additions & 3 deletions packages/web3-core-requestmanager/src/jsonrpc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@

// Initialize Jsonrpc as a simple object with utility functions.
var Jsonrpc = {
messageId: 0
// This is the starting counter for the Jsonrpc.id.
// Pick a random number between 0 and the maximum safe integer
messageId: Math.floor(Math.random() * Number.MAX_SAFE_INTEGER)
};

/**
Expand All @@ -42,8 +44,14 @@ Jsonrpc.toPayload = function (method, params) {
throw new Error('JSONRPC method should be specified for params: "'+ JSON.stringify(params) +'"!');
}

// advance message ID
Jsonrpc.messageId++;
if(Jsonrpc.messageId === Number.MAX_SAFE_INTEGER) {
// if the maximum safe integer has been reached, restart from a random number
Jsonrpc.messageId = Math.floor(Math.random() * Number.MAX_SAFE_INTEGER)
}
else {
// advance message ID
Jsonrpc.messageId++;
}

return {
jsonrpc: '2.0',
Expand Down