Add integration tests. #2693

levino · 2019-04-16T08:11:01Z

Description

I only added a simple integration test against a local ganache.

Fixes #2682

nivida · 2019-04-16T08:13:47Z

We have currently a similar PR open here: #2688

levino · 2019-04-16T08:14:25Z

~~Mine is much simpler.~~ Not so simple any more.

nivida · 2019-04-16T08:16:09Z

Yep, just looked at the other and it looks way more complicated. We should probably merge this PR and use your structure as a base. @micahriggan @szerintedmi Would that be okay for both you?

levino · 2019-04-16T08:25:29Z

.travis.yml

+        sources:
+            - ubuntu-toolchain-r-test
+        packages:
+            - g++-4.8


I think 4 space indent just follows eslint.config.

docker-compose.yml

szerintedmi · 2019-04-16T08:27:12Z

Yep, just looked at the other and it looks way more complicated. We should probably merge this PR and use your structure as a base. @micahriggan @szerintedmi Would that be okay for both you?

I don't have a strong opinion, I'm just happy it's happening :) I need to try both locally to tell which approach would I prefer.

levino · 2019-04-16T08:27:47Z

docker-compose.yml

+            - nm21:/home/node/packages/web3-providers-ipc/node_modules
+            - nm22:/home/node/packages/web3-providers-ws/node_modules
+            - nm23:/home/node/packages/web3-shh/node_modules
+            - nm24:/home/node/packages/web3-utils/node_modules


These are necessary so that the npm install in the docker world does not write to the host and writes deps as root and also possibly for a different operating system.

levino · 2019-04-16T08:29:29Z

To run locally it should suffice to:

npm install
npm run test:integration

Requirement: docker-compose installed on local machine.

levino · 2019-04-16T08:30:44Z

The whole lerna crazyness is only slowing things down in this repo (e.g. one has to rollup all packages before one can run a test... WTF?). It should be undone asap.

levino · 2019-04-16T08:32:04Z

Oh this part from the CI output is golden:

Installing to /home/travis/build/ethereum/web3.js/packages/web3-eth-iban/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-shh' in 9.6s:
> web3-shh@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-shh
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-shh/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-eth-ens' in 9.5s:
> web3-eth-ens@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-eth-ens
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-eth-ens/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-eth' in 9.8s:
> web3-eth@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-eth
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-eth/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-core-helpers' in 9.1s:
> web3-core-helpers@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-core-helpers
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-core-helpers/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-core-method' in 11.4s:
> web3-core-method@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-core-method
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-core-method/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-providers' in 22.3s:
> web3-providers@1.0.0-beta.52 dtslint /home/travis/build/ethereum/web3.js/packages/web3-providers
> dtslint types --onlyTestTsNext
Installing to /home/travis/build/ethereum/web3.js/packages/web3-providers/node_modules/dtslint/typescript-installs/next...
Installed!
lerna info run Ran npm script 'dtslint' in 'web3-core' in 15.3s:

szerintedmi · 2019-04-16T08:32:55Z

packages/web3/package.json

@@ -52,6 +52,9 @@
        "build": "rollup -c",
        "dev": "rollup -c -w",
        "test": "jest",
+        "docker": "docker-compose run --workdir='/home/node/packages/web3' web3 npm run",
+        "predocker": "docker-compose run web3 npm install --unsafe-perm",
+        "test:integration": "npm run docker test --testMatch='/**/*.Itest.js'",


do we need to introduce a new file extension? Can it be done with --scope flag?

I f****g hate jest and do not know what kind of magic it can do. It is very probable that there is a more elegant way.

tell me.. I spent 10 minutes writing the actual tests / docker stuff and hours in Lerna and Jest swamp </rant>

levino · 2019-04-16T08:33:22Z

Why are linting, coverage and tests not run in parallel? There is no need to wait for linting to run the tests. Is TravisCI so bad?

nivida · 2019-04-16T08:35:47Z

The whole lerna crazyness is only slowing things down in this repo (e.g. one has to rollup all packages before one can run a test... WTF?). It should be undone asap.

Yes, it will be possible to remove lerna if we move the modules together to one web3 module.

Why are the tests not run in parallel? There is no need to wait for linting to run the tests. Is TravisCI so bad?

Didn't look at it closer. But yes we could parallelize it. Hopefully, GitHub will soon release the GitHub actions also for public repositories.

levino · 2019-04-16T08:35:52Z

Boom, tests pass.

Missing whitespace.

packages/web3/integrationTests/SendTransaction.Itest.js

coveralls · 2019-04-16T08:38:18Z

Coverage remained the same at 95.643% when pulling 2e44b74 on Levino:feature/add-integration-tests into 704be57 on ethereum:1.0.

levino · 2019-04-16T09:49:14Z

packages/web3/package.json

@@ -52,6 +52,9 @@
        "build": "rollup -c",
        "dev": "rollup -c -w",
        "test": "jest",
+        "docker": "docker-compose run --workdir='/home/node/packages/web3' web3 npm run",
+        "predocker": "docker-compose run web3 npm install --unsafe-perm",


This will go into the docker container for service web3 and install all deps. Because I added a prepare step to the root package.json scripts after npm install lerna will bootstrap and also build all packages (all in the docker container / the mounted volumes). Then the integration tests will be run in the docker container.

The only problem I just realised is that the build output will be written to the host. One must also create volumes for all the /build folders. Damn lerna!

Ah, I think i got it, thanks. (I still getting lost in this spaghetti build process, I can't see the reason of all of this complication in the package)

I do not find it so spaghetti to be honest. I mean lerna is annoying and makes no sense here but other than that is usualy that one npm script triggers the other...

I made virtual /dist folders for the docker container.

nivida · 2019-04-16T10:36:45Z

@levino I would rename the folder integrationTests to e2e.

szerintedmi · 2019-04-16T12:30:27Z

To run locally it should suffice to:
npm install
npm run test:integration
Requirement: docker-compose installed on local machine.

it hangs for me on this (after successful npm install, pulled PR branch just now)

$ npm run test:integration

> web3@1.0.0-beta.52 test:integration /Users/petro/ether/web3.js
> lerna run test:integration

lerna notice cli v3.13.1
lerna info Executing command in 1 package: "npm run test:integration"

micahriggan · 2019-04-16T13:37:37Z

Yep, just looked at the other and it looks way more complicated. We should probably merge this PR and use your structure as a base. @micahriggan @szerintedmi Would that be okay for both you?

That's fine with me, mine was based off of the wrong branch anyway.

There are some aspects to mine that I think are important, and are missing here

Testing websockets
Testing geth and parity

Other than that, nice work, glad this is happening

levino · 2019-04-16T20:37:00Z

To run locally it should suffice to:
npm install
npm run test:integration
Requirement: docker-compose installed on local machine.
it hangs for me on this (after successful npm install, pulled PR branch just now)
$ npm run test:integration

> web3@1.0.0-beta.52 test:integration /Users/petro/ether/web3.js
> lerna run test:integration

lerna notice cli v3.13.1
lerna info Executing command in 1 package: "npm run test:integration"

It just takes very long. You can go to the package (cd package/web3) and then run the tests there npm run test:integration then you can see the progress.

levino · 2019-04-16T20:38:59Z

Testing websockets

Testing geth and parity

Please be more specific.

Websockets should be testable against ganache, right? Can geth and parity be put into any state? Especially empty state? Or do you want to run integration tests against Kovan etc? I think that is a very bad idea, because of the statefulness.

micahriggan · 2019-04-16T22:11:30Z

Parity and Geth both have a dev mode, which start empty chains, I was attempting to utilize that mode in my MR.

As for the websockets on ganache, definitely, those should be tested as well

But I think it'd be smart to have the tests run against each node, for each protocol. So that way you know if there's a breaking change that affects one node, or if there's some missing functionality.

I think what you have is good to merge for a starting point. The other nodes and protocol stuff can be done later

…ion-tests

levino · 2019-04-25T05:59:55Z

Remarks should have been adressed. Anything else?

levino · 2019-04-25T06:07:01Z

packages/web3-eth-contract/tests/src/methods/SendContractMethodTest.js

+            {},
+            {},
+            allEventsLogDecoderMock,
+            abiModelMock


These changes came from npm run travis.

levino · 2019-04-25T06:07:09Z

packages/web3-eth-accounts/src/models/Account.js

+        const mac = keccak256(Buffer.concat([derivedKey.slice(16, 32), Buffer.from(ciphertext, 'hex')])).replace(
+            '0x',
+            ''
+        );


These changes came from npm run travis.

levino · 2019-04-25T09:36:44Z

The build fails because the type defs do not pass linting for TsNext any more. I think that setup is badly configured. Branch 1.0 should also not build atm.

levino · 2019-06-11T09:38:17Z

I can make this much simpler. I would only do it if there is interest in actually merging this. Is there @nivida ?

nivida · 2019-06-12T08:15:31Z

Thanks for asking @levino. I've renamed all the branches for having a better overview and to prepare the coming stable release. I will use this PR as base for the integration tests in the 2.x branch.

nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Apr 16, 2019

szerintedmi mentioned this pull request Apr 16, 2019

Integration tests #2682

Closed

Add integration tests.

0203645

levino force-pushed the feature/add-integration-tests branch from e2b912e to 0203645 Compare April 16, 2019 08:21

levino commented Apr 16, 2019

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

levino commented Apr 16, 2019

View reviewed changes

szerintedmi reviewed Apr 16, 2019

View reviewed changes

Update docker-compose.yml

bc5add9

Missing whitespace.

nivida mentioned this pull request Apr 16, 2019

WIP: e2e tests #2688

Closed

12 tasks

levino commented Apr 16, 2019

View reviewed changes

packages/web3/integrationTests/SendTransaction.Itest.js Outdated Show resolved Hide resolved

Update packages/web3/integrationTests/SendTransaction.Itest.js

e47802d

levino commented Apr 16, 2019

View reviewed changes

Merge upstream changes.

d3dff79

nivida mentioned this pull request Apr 23, 2019

Web3.js Stable Release 1.0 #2684

Closed

Merge remote-tracking branch 'ethereum/1.0' into feature/add-integrat…

c345b7a

…ion-tests

levino commented Apr 25, 2019

View reviewed changes

Rename test folders.

2e44b74

levino force-pushed the feature/add-integration-tests branch from 8b9b28f to 2e44b74 Compare April 25, 2019 06:23

nivida closed this Jun 12, 2019

cgewecke mentioned this pull request Oct 4, 2019

Proposal to add E2E and Integration testing on 1.x branch #3098

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration tests. #2693

Add integration tests. #2693

levino commented Apr 16, 2019 •

edited by nivida

Loading

nivida commented Apr 16, 2019

levino commented Apr 16, 2019 •

edited

Loading

nivida commented Apr 16, 2019 •

edited

Loading

levino Apr 16, 2019

szerintedmi commented Apr 16, 2019

levino Apr 16, 2019

levino commented Apr 16, 2019

levino commented Apr 16, 2019

levino commented Apr 16, 2019 •

edited

Loading

szerintedmi Apr 16, 2019 •

edited

Loading

levino Apr 16, 2019

szerintedmi Apr 16, 2019

levino commented Apr 16, 2019 •

edited

Loading

nivida commented Apr 16, 2019 •

edited

Loading

levino commented Apr 16, 2019

coveralls commented Apr 16, 2019 •

edited

Loading

levino Apr 16, 2019

szerintedmi Apr 16, 2019 •

edited

Loading

levino Apr 16, 2019

levino Apr 16, 2019

nivida commented Apr 16, 2019 •

edited

Loading

szerintedmi commented Apr 16, 2019 •

edited

Loading

micahriggan commented Apr 16, 2019

levino commented Apr 16, 2019

levino commented Apr 16, 2019 •

edited

Loading

micahriggan commented Apr 16, 2019 •

edited

Loading

levino commented Apr 25, 2019

levino Apr 25, 2019

levino Apr 25, 2019

levino commented Apr 25, 2019 •

edited

Loading

levino commented Jun 11, 2019

nivida commented Jun 12, 2019

Add integration tests. #2693

Add integration tests. #2693

Conversation

levino commented Apr 16, 2019 • edited by nivida Loading

Description

nivida commented Apr 16, 2019

levino commented Apr 16, 2019 • edited Loading

nivida commented Apr 16, 2019 • edited Loading

Choose a reason for hiding this comment

szerintedmi commented Apr 16, 2019

Choose a reason for hiding this comment

levino commented Apr 16, 2019

levino commented Apr 16, 2019

levino commented Apr 16, 2019 • edited Loading

szerintedmi Apr 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

levino commented Apr 16, 2019 • edited Loading

nivida commented Apr 16, 2019 • edited Loading

levino commented Apr 16, 2019

coveralls commented Apr 16, 2019 • edited Loading

Choose a reason for hiding this comment

szerintedmi Apr 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nivida commented Apr 16, 2019 • edited Loading

szerintedmi commented Apr 16, 2019 • edited Loading

micahriggan commented Apr 16, 2019

levino commented Apr 16, 2019

levino commented Apr 16, 2019 • edited Loading

micahriggan commented Apr 16, 2019 • edited Loading

levino commented Apr 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

levino commented Apr 25, 2019 • edited Loading

levino commented Jun 11, 2019

nivida commented Jun 12, 2019

levino commented Apr 16, 2019 •

edited by nivida

Loading

levino commented Apr 16, 2019 •

edited

Loading

nivida commented Apr 16, 2019 •

edited

Loading

levino commented Apr 16, 2019 •

edited

Loading

szerintedmi Apr 16, 2019 •

edited

Loading

levino commented Apr 16, 2019 •

edited

Loading

nivida commented Apr 16, 2019 •

edited

Loading

coveralls commented Apr 16, 2019 •

edited

Loading

szerintedmi Apr 16, 2019 •

edited

Loading

nivida commented Apr 16, 2019 •

edited

Loading

szerintedmi commented Apr 16, 2019 •

edited

Loading

levino commented Apr 16, 2019 •

edited

Loading

micahriggan commented Apr 16, 2019 •

edited

Loading

levino commented Apr 25, 2019 •

edited

Loading