Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of new Error with Web3Errors for EIP-712 util methods #6291

Closed
spacesailor24 opened this issue Jul 18, 2023 · 0 comments · Fixed by #6641
Closed

Replace use of new Error with Web3Errors for EIP-712 util methods #6291

spacesailor24 opened this issue Jul 18, 2023 · 0 comments · Fixed by #6641
Assignees
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@spacesailor24
Copy link
Contributor

In this newly added file (packages/web3-eth-abi/src/eip_712.ts) for PR #6286, there are three errors that were copied over:

when our use of ethers' ABI encoder is refactored, these util methods should be revisited and updated accordingly. The above mentioned errors should be converted to Web3Errors if still applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants