Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch information on the type for gas for the signTransaction method. #5674

Closed
1 task done
FidelVe opened this issue Dec 2, 2022 · 3 comments
Closed
1 task done
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation

Comments

@FidelVe
Copy link

FidelVe commented Dec 2, 2022

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to say about Web3.js' documentation?

The description of the parameters for the TX object describes the gas parameter as of type string but the example afterwards uses a value of type number

Examples/References

screenshot for the parameters section
Screenshot from 2022-12-01 21-30-54

screenshot for the examples used
Screenshot from 2022-12-01 21-31-17

link of the section in the docs:

https://web3js.readthedocs.io/en/v1.2.11/web3-eth-accounts.html#signtransaction

@FidelVe FidelVe added the Documentation Relates to project wiki or documentation label Dec 2, 2022
@spacesailor24
Copy link
Contributor

Hi there, thank you for bringing this to our attention!

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Dec 2, 2022
@FidelVe
Copy link
Author

FidelVe commented Dec 2, 2022

Hi there, thank you for bringing this to our attention!

Is the correct type number? I think it should be appropriate for the param to accept a hex string as a value.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Feb 3, 2023
@luu-alex luu-alex removed the Stale Has not received enough activity label Feb 3, 2023
@jdevcs jdevcs closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Development

No branches or pull requests

4 participants