From df6595ec7e75fdf8fb524a039c32a030fc1075e9 Mon Sep 17 00:00:00 2001
From: "TAMURA, Kent" <tkent@chromium.org>
Date: Tue, 6 Feb 2024 15:18:09 +0900
Subject: [PATCH] html: Tests for field-sizing (#44346)

This includes tests to confirm size/cols/rows are not presentational hints.

Issue: https://github.com/whatwg/html/issues/6807
---
 ...ber.tentative.html => field-sizing-input-number.html} | 0
 ...-text.tentative.html => field-sizing-input-text.html} | 0
 ...ng-select.tentative.html => field-sizing-select.html} | 0
 ...extarea.tentative.html => field-sizing-textarea.html} | 0
 html/rendering/widgets/input-text-size.html              | 8 +++++++-
 html/rendering/widgets/textarea-cols-rows.html           | 9 ++++++++-
 6 files changed, 15 insertions(+), 2 deletions(-)
 rename html/rendering/widgets/{field-sizing-input-number.tentative.html => field-sizing-input-number.html} (100%)
 rename html/rendering/widgets/{field-sizing-input-text.tentative.html => field-sizing-input-text.html} (100%)
 rename html/rendering/widgets/{field-sizing-select.tentative.html => field-sizing-select.html} (100%)
 rename html/rendering/widgets/{field-sizing-textarea.tentative.html => field-sizing-textarea.html} (100%)

diff --git a/html/rendering/widgets/field-sizing-input-number.tentative.html b/html/rendering/widgets/field-sizing-input-number.html
similarity index 100%
rename from html/rendering/widgets/field-sizing-input-number.tentative.html
rename to html/rendering/widgets/field-sizing-input-number.html
diff --git a/html/rendering/widgets/field-sizing-input-text.tentative.html b/html/rendering/widgets/field-sizing-input-text.html
similarity index 100%
rename from html/rendering/widgets/field-sizing-input-text.tentative.html
rename to html/rendering/widgets/field-sizing-input-text.html
diff --git a/html/rendering/widgets/field-sizing-select.tentative.html b/html/rendering/widgets/field-sizing-select.html
similarity index 100%
rename from html/rendering/widgets/field-sizing-select.tentative.html
rename to html/rendering/widgets/field-sizing-select.html
diff --git a/html/rendering/widgets/field-sizing-textarea.tentative.html b/html/rendering/widgets/field-sizing-textarea.html
similarity index 100%
rename from html/rendering/widgets/field-sizing-textarea.tentative.html
rename to html/rendering/widgets/field-sizing-textarea.html
diff --git a/html/rendering/widgets/input-text-size.html b/html/rendering/widgets/input-text-size.html
index 7f2948280c072d..fb3008df08f98f 100644
--- a/html/rendering/widgets/input-text-size.html
+++ b/html/rendering/widgets/input-text-size.html
@@ -13,6 +13,7 @@
 <input id="size20" size="20">
 <input id="size21" size="21">
 <input id="computed" style="border:none; padding:0;" size="19">
+<input id="computedNone" style="display:none" size="17">
 
 <script>
 test(() => {
@@ -34,6 +35,11 @@
   const computedString = getComputedStyle(computed).width;
   assert_equals(computed.offsetWidth,
       parseInt(computedString.substring(0, computedString.length - 2)));
-}, 'Size attribute value affects computed style');
+}, 'Size attribute value affects layout-dependent computed style');
+
+test(() => {
+  const computedString = getComputedStyle(computedNone).width;
+  assert_equals(computedString, 'auto');
+}, 'Size attribute value is not a presentational hint');
 </script>
 
diff --git a/html/rendering/widgets/textarea-cols-rows.html b/html/rendering/widgets/textarea-cols-rows.html
index 012c5aa153dc34..6ad24a2eb8b399 100644
--- a/html/rendering/widgets/textarea-cols-rows.html
+++ b/html/rendering/widgets/textarea-cols-rows.html
@@ -8,6 +8,7 @@
 <textarea id="missing"></textarea>
 <textarea id="invalid" cols="-1" rows="-1"></textarea>
 <textarea id="computed" style="border:none; padding:0;" cols="19" rows="5"></textarea>
+<textarea id="computedNone" style="display:none" cols="17" rows="7"></textarea>
 
 <textarea id="cols0" cols="0"></textarea>
 <textarea id="cols1" cols="1"></textarea>
@@ -52,6 +53,12 @@
   const computedHeight = getComputedStyle(computed).height;
   assert_equals(computed.offsetHeight,
       parseInt(computedHeight.substring(0, computedHeight.length - 2)));
-}, 'Cols/rows attribute values affect computed style');
+}, 'Cols/rows attribute values affect layout-dependent computed style');
+
+test(() => {
+  const computedNoneStyle = getComputedStyle(computedNone);
+  assert_equals(computedNoneStyle.width, 'auto');
+  assert_equals(computedNoneStyle.height, 'auto');
+}, 'Cols/rows attribute values are not presentational hints');
 </script>