Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: AssetGeneratorDataUrlFunction should align with webpack #8538

Closed
Tracked by #8445
GiveMe-A-Name opened this issue Nov 26, 2024 · 0 comments · Fixed by #8614
Closed
Tracked by #8445

[Feature]: AssetGeneratorDataUrlFunction should align with webpack #8538

GiveMe-A-Name opened this issue Nov 26, 2024 · 0 comments · Fixed by #8614
Labels
feat New feature or request

Comments

@GiveMe-A-Name
Copy link
Member

What problem does this feature solve?

In Rspack, module.generator.dataUrl function mode signature is ({ content: string, filename: string }) => string, it is not align with webpack.
In webpack, module.generator.dataUrl function mode signature like bellow code:

export type AssetGeneratorDataUrlFunction = (
	source: string | Buffer,
	context: {filename: string; module: Module
) => string;

What does the proposed API of configuration look like?

  • export Module API
  • function signature is align with webpack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants