You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there. First of all, thanks for this awesome project! It really cut down the amount of work necessary to achieve linting through GitHub Actions.
This is a feature request/suggestion with a following pull request if you approve of such addition.
Basically, when linters finish with only warning annotations as a result, the GitHub "Check" will have the conclusion attribute set to success. This causes GitHub to collapse the checks section (since all the checks are green checkmarks) and might cause developers to miss that the linter actually found some warnings!
As you can see, the checks section here is collapsed
⬇️
But upon expanding it, our linter actually found a couple of warnings! Some people might easily miss these annotations.
⬇️
My suggestion to this is to add a setting to mark such cases as neutral instead.
⬇️
neutral is also the only status that doesn't look like a success/failure. (success would encourage developers to ignore it; failure would be too strict and should be reserved to actual errors)
⬇️
Would you be interested in adding such a feature? I'm already running a fork that changes the logic directly and it's working fine for SwiftLint. An actual pull request would have this as a setting instead of hardcoded of course.
Thanks.
The text was updated successfully, but these errors were encountered:
Hi there. First of all, thanks for this awesome project! It really cut down the amount of work necessary to achieve linting through GitHub Actions.
This is a feature request/suggestion with a following pull request if you approve of such addition.
Basically, when linters finish with only warning annotations as a result, the GitHub "Check" will have the conclusion attribute set to
success
. This causes GitHub to collapse the checks section (since all the checks are green checkmarks) and might cause developers to miss that the linter actually found some warnings!As you can see, the checks section here is collapsed
⬇️
But upon expanding it, our linter actually found a couple of warnings! Some people might easily miss these annotations.
⬇️
My suggestion to this is to add a setting to mark such cases as
neutral
instead.⬇️
neutral
is also the only status that doesn't look like a success/failure. (success
would encourage developers to ignore it;failure
would be too strict and should be reserved to actual errors)⬇️
Would you be interested in adding such a feature? I'm already running a fork that changes the logic directly and it's working fine for SwiftLint. An actual pull request would have this as a setting instead of hardcoded of course.
Thanks.
The text was updated successfully, but these errors were encountered: