Skip to content
This repository has been archived by the owner on Feb 26, 2025. It is now read-only.

Module switch menu is not based on the installed modules list #27

Closed
jeffnm opened this issue Jan 11, 2017 · 3 comments
Closed

Module switch menu is not based on the installed modules list #27

jeffnm opened this issue Jan 11, 2017 · 3 comments
Assignees

Comments

@jeffnm
Copy link
Member

jeffnm commented Jan 11, 2017

While testing the upgrade with a missing configuration file, I installed skipped the Licensing module (because I had deleted the configuration.ini file). All the other modules installed fine, but the module switch list in the menu still had the licensing module as an option. Clicking it results in either a not found or a 500 error. Ideally a module only appears in the Change Module list when it's installed according to the common/configuration.ini file.

@jcuenod
Copy link

jcuenod commented Jan 11, 2017

hmm, I think this is implemented on a per module basis. I can look into changing these though.

@jcuenod jcuenod self-assigned this Jan 11, 2017
@jeffnm
Copy link
Member Author

jeffnm commented Jan 11, 2017

@jcuenod I think you are right. This is probably not something you should worry about at this point, but rather something that we'll fix in the next release when we continue to combine common elements. That said, if you want to take a stab at it now, that's fine too, but I can't guarantee we'll get the result into the 2.0 beta release.

@jcuenod
Copy link

jcuenod commented Jan 11, 2017

I don't think it will be hard - I suspect it will actually simplify code and just be a matter of require_once my common Config.php and then just query it. That's already happening in index.php but yes, getting this change into 2.0 is not essential in my mind it would be good to fix that though.

@jeffnm jeffnm closed this as completed Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants