test: Add more call tests #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 62 62
Lines 9052 9062 +10
=======================================
+ Hits 8893 8903 +10
Misses 159 159 |
axic
reviewed
Oct 5, 2020
| (func $double (param i32) (result i64) | ||
| local.get 0 | ||
| i64.extend_i32_u | ||
| local.get 0 |
There was a problem hiding this comment.
Is the point of this test that the same local is used twice?
axic
reviewed
Oct 5, 2020
| @@ -205,6 +233,36 @@ TEST(execute_call, call_indirect_uninited_table) | |||
| EXPECT_THAT(execute(module, 3, {4}), Traps()); | |||
| } | |||
|
|
|||
| TEST(execute_call, call_indirect_shared_stack_space) | |||
There was a problem hiding this comment.
Seems to be a dup of imported_functions_call_indirect ?
There was a problem hiding this comment.
Both are simplified variants of it. They can detect an implementation defect in #572, so I keep them as they are.
gumb0
reviewed
Oct 5, 2020
test/unittests/execute_call_test.cpp
Outdated
| { | ||
| /* wat2wasm | ||
| (module | ||
| (func $double (param i32) (result i64) |
There was a problem hiding this comment.
It's hard to guess what these tests check... Is i64 result required here? If not, maybe make it i32 for simplicity and more focused test?
gumb0
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.