Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add option for relay subscriptions to drop old messages once channel is full #871

Closed
richard-ramos opened this issue Nov 7, 2023 · 1 comment
Closed

chore: add option for relay subscriptions to drop old messages once channel is full #871

richard-ramos opened this issue Nov 7, 2023 · 1 comment

Comments

@richard-ramos
Copy link
Member

Describe the bug
The idea would be for the subscription to act as a ring buffer and drop old messages in case the number of messages exceed the cache capacity. See discussion in #866 (comment)
@fryorcraken fryorcraken added this to Waku Nov 7, 2023
@richard-ramos richard-ramos mentioned this issue Nov 7, 2023
Merged
5 tasks
@chair28980 chair28980 moved this to Icebox in Waku Dec 5, 2023
@chaitanyaprem
Copy link
Collaborator

Closing the issue as it is descoped for go-waku.

If there is an issue noticed with current subscription mechanism, then this can be looked at.

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richard-ramos @chaitanyaprem