Skip to content

Latest commit

 

History

History
60 lines (51 loc) · 3.5 KB

DAOsign_m2_keeganquigley.md

File metadata and controls

60 lines (51 loc) · 3.5 KB

Evaluation

Number Deliverable Accepted Link Notes
0a. License
LICENSE Apache 2.0
0b. Documentation
Readme Readme could be updated.
0c. Testing and Testing Guide
https://github.com/DAOsign/daosign-ink-js-sdk?tab=readme-ov-file#testing All passing.
0d. Docker
https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#with-docker Ok.
1. DAOsign Ink! JS SDK
Github Repo, npm package Ok.
2. DAOsign Application Integration
Github Repo Ok.

General Notes

Passed but for the next milestone consider writing some better docs.

Only two unit tests.

UPDATE: All unit tests now passing with good coverage:

 PASS  __tests__/DaosignPolkadotContractInteractor.test.ts (6.888 s)
  numberToArray
    ✓ should correctly convert positive numbers (3 ms)
    ✓ should correctly handle zero (1 ms)
    ✓ should correctly convert large numbers (1 ms)
    ✓ should throw an error for numbers exceeding maximum safe integer (13 ms)
    ✓ should throw an error for negative numbers
  sendTransaction
    ✓ should send a transaction successfully with valid parameters (16 ms)
    ✓ should handle transaction failure gracefully
    ✓ should handle insufficient funds and network errors gracefully (1 ms)
  Proof storage functions
    ✓ should store proof of authority successfully with valid parameters (2 ms)
    ✓ should store proof of signature successfully with valid parameters (1 ms)
    ✓ should store proof of agreement successfully with valid parameters (1 ms)
    ✓ should fail storing proof of authority with invalid parameters (1 ms)
    ✓ should fail storing proof of signature with invalid parameters (1 ms)
    ✓ should fail storing proof of agreement with invalid parameters (1 ms)
    ✓ should handle network issues or contract errors in proof storage
  Check wallet balance
    ✓ should get account balance successfully (29 ms)
    ✓ should throw an error if account balance retrieval fails (13 ms)

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |    93.1 |       75 |    92.3 |   92.72 |                   
 index.ts |    93.1 |       75 |    92.3 |   92.72 | 72-75,116         
----------|---------|----------|---------|---------|-------------------
Test Suites: 1 passed, 1 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        6.969 s