Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture-in-Picture (PiP) #226

Closed
3 of 5 tasks
beaufortfrancois opened this issue Jan 29, 2018 · 14 comments
Closed
3 of 5 tasks

Picture-in-Picture (PiP) #226

beaufortfrancois opened this issue Jan 29, 2018 · 14 comments
Assignees

Comments

@beaufortfrancois
Copy link

beaufortfrancois commented Jan 29, 2018

Hello TAG!

I'm requesting a TAG review of:

Further details:

You should also know that...

The API is available in Chrome behind a switch. --enable-blink-features=PictureInPictureAPI
Implementation bugs are tracked here.

We'd prefer the TAG provide feedback as:

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and notify @beaufortfrancois and @mounirlamouri
@torgo
Copy link
Member

torgo commented Jan 31, 2018

Taken up at london f2f.

@torgo torgo added this to the tag-f2f-london-2018-01-31 milestone Jan 31, 2018
@beaufortfrancois
Copy link
Author

Feel free to ping us anytime during the discussion if you have any questions.

@torgo
Copy link
Member

torgo commented Feb 2, 2018

Discussed in break-out on day 3 of our f2f...

@triblondon
Copy link

triblondon commented Feb 2, 2018

Points from TAG discussion, @cynthia will discuss with the group

  • Why just video? We see use cases for canvas or even arbitrary HTML content
    • Aircraft/train journey map / journey metrics
    • Heads up display for games / apps
  • Top and Start props in explainer missing from spec
  • Noted that requires user interaction
  • We'd like to see some more security considerations (S&P questionnaire?)

@beaufortfrancois
Copy link
Author

I've just updated the explainer (IDL and example) to reflect the current state of the specification. Sorry for the confusion. w3c/picture-in-picture#51

The S&P questionnaire has been filled at the same time as this TAG review request and is available at https://github.com/WICG/picture-in-picture/blob/master/security-privacy-questionnaire.md

Use cases for canvas and HTML content are exciting indeed. There are many security aspects that would need to be addressed though. What we'd like first is a minimal viable product and iterate from it.
See https://wicg.github.io/picture-in-picture/#security-considerations

@beaufortfrancois
Copy link
Author

FYI I've just added a section to the explainer on how to use canvas for PiP: https://github.com/WICG/picture-in-picture/blob/master/explainer.md#video-restrictions

@beaufortfrancois
Copy link
Author

@cynthia @triblondon @torgo Is there anything else we can do on our side to help?

@cynthia
Copy link
Member

cynthia commented Feb 26, 2018

@beaufortfrancois Apologies for the silence, can I spend a day to digest the updates and discuss this in a upcoming call if there is anything that needs to be revisited?

(Otherwise, we will revisit this in a call and close if it is a LGTM for the group.)

@beaufortfrancois
Copy link
Author

No problem. Just wanted to make sure there wasn't anything blocking from our side.

@beaufortfrancois
Copy link
Author

@cynthia Did you have a chance to look at it?

@cynthia
Copy link
Member

cynthia commented Mar 6, 2018

@beaufortfrancois Yes, I had one last bit that got delayed (the S&P questionnaire) and all of this looks good to me. The canvas use case is something that honestly we didn't think about, and I think it would be a good start to let content authors test the waters and iterate after the MVP is out.

I'll bring this up in a upcoming call and see if there are any issues that I missed during the review. (always good to have a second pair of eyes)

Thanks a lot for your patience and cooperation! We really appreciate it.

@beaufortfrancois
Copy link
Author

@cynthia Thank you!

Hopefully 2018-03-13-telcon will include Picture-in-Picture.

@cynthia
Copy link
Member

cynthia commented Mar 13, 2018

@beaufortfrancois
Taken up in 2018-03-13 telco. We're happy to see this new feature as a part of the platform, and if you do expand on it (which we would love to see happen) please let us know. Thanks again for raising the review!

@cynthia cynthia closed this as completed Mar 13, 2018
@beaufortfrancois
Copy link
Author

For future reference, here are the meeting notes: https://github.com/w3ctag/meetings/blob/gh-pages/2018/telcons/03-13-minutes.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants