Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move browser specific settings to browser_specific_settings #115

Open
carlosjeurissen opened this issue Oct 21, 2021 · 2 comments
Labels
enhancement Enhancement or change to an existing feature implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari inconsistency Inconsistent behavior across browsers neutral: chrome Not opposed or supportive from Chrome proposal Proposal for a change or new feature

Comments

@carlosjeurissen
Copy link
Contributor

Several manifest properties are browser specific like minimum_chrome_version and minimum_opera_version. To align with Safari, Firefox and edgeHTML, these should be defined in browser_specific_settings.

"browser_specific_settings": {
  "chromium": {
    "strict_min_version": "14",
    "strict_max_version": "20",
    "key": "some key",
    "container": "some container"
  },
  "opera": {
    "strict_min_version": "14",
    "strict_max_version": "20"
  }
}

Some of these can be specified as being the same for each platform. Like strict_min_version and strict_max_version, while some are unique for a specific platform like key and container are for Chromium.

@xeenon xeenon added enhancement Enhancement or change to an existing feature inconsistency Inconsistent behavior across browsers labels Oct 25, 2021
@xeenon xeenon added the proposal Proposal for a change or new feature label Aug 31, 2022
@xeenon
Copy link
Collaborator

xeenon commented Sep 1, 2022

Safari already implements support for:

"browser_specific_settings": {
  "safari": {
    "strict_min_version": "14",
    "strict_max_version": "15",
  }
}

I believe Firefox does as well for the firefox key.

@Rob--W
Copy link
Member

Rob--W commented Jan 16, 2025

Relevant note: Chrome is open to support for browser_specific_settings.strict_min_version, but it is not a priority to implement. This was discussed during TPAC last yet, with meeting notes captured at:

* [Issue 115](https://github.com/w3c/webextensions/issues/115): Proposal: move browser specific settings to browser_specific_settings
* [rob] Are you neutral or opposed towards adding chrome to browser_specific_settings?
* [devlin] What is put there?
* [rob] E.g. putting strict_min_version.
* [timothy] We use it in that way too.
* [rob] Chrome could then add a browser_specific_settings.chrome.strict_min_version key with the semantics of minimum_chrome_version.
* [devlin] No objections, would not be a priority to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or change to an existing feature implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari inconsistency Inconsistent behavior across browsers neutral: chrome Not opposed or supportive from Chrome proposal Proposal for a change or new feature
Projects
None yet
Development

No branches or pull requests

3 participants