Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing dialog-modal_datepicker.js test #2938

Closed
howard-e opened this issue Feb 26, 2024 · 1 comment
Closed

Failing dialog-modal_datepicker.js test #2938

howard-e opened this issue Feb 26, 2024 · 1 comment
Assignees
Labels
bug Code defects; not for inaccurate prose regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@howard-e
Copy link
Contributor

howard-e commented Feb 26, 2024

A failure I've confirmed to not be flaky, first observed in #2936:

error shown in build: Element query returned no results: #example [role="dialog"] table.dates td[data-date="2019-01-01"]
not ok 144 - dialog-modal_datepicker › content/patterns/dialog-modal/examples/datepicker-dialog.html [data-test-id="gridcell-button-aria-selected"]: aria-selected on selected date
  ---
    name: AssertionError
    message: >-
      Element query returned no results: #example [role="dialog"] table.dates
      td[data-date="2019-01-01"]
    assertion: fail
    at: |-
      Object.queryElements (test/util/queryElements.js:16:7)
      async assertAttributeValues (test/util/assertAttributeValues.js:17:18)
      async test/tests/dialog-modal_datepicker.js:238:5
  ...

I'm unsure why this happens at the moment but raising the issue because it doesn't seem to be unique to #2936. That PR also doesn't affect files which can cause that. The test is currently at test/tests/dialog-modal_datepicker.js#L228:L266

I'm also able to consistently replicate this failure on main by running the following command locally:

npm run regression -- -t test/tests/dialog-modal_datepicker.js

@howard-e howard-e changed the title Failing dialog-modal_datepicker.js test Failing dialog-modal_datepicker.js test Feb 26, 2024
@a11ydoer a11ydoer added bug Code defects; not for inaccurate prose regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo labels Feb 27, 2024
@a11ydoer a11ydoer self-assigned this Feb 27, 2024
@howard-e
Copy link
Contributor Author

I haven't been able to reproduce or observe in newer PRs this issue happening since the ~week it was reported. Changes may have happened in the infrastructure around that time which helped prevent this from happening. Will reopen if it pops up once again

cc @ccanash

@github-project-automation github-project-automation bot moved this from In Progress to In production / Completed in 2024 Ops and maintenance support for ARIA-AT and APG Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
Status: In production / Completed
Development

No branches or pull requests

2 participants