Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include skipto.js to the examples/js folder for wai-aria-practices compatibility #2387

Closed
evmiguel opened this issue Jun 28, 2022 · 1 comment · Fixed by #2389
Closed

Include skipto.js to the examples/js folder for wai-aria-practices compatibility #2387

evmiguel opened this issue Jun 28, 2022 · 1 comment · Fixed by #2389

Comments

@evmiguel
Copy link
Contributor

evmiguel commented Jun 28, 2022

Currently, the wai-aria-practices script, which formats the examples for APG, depends on the files in the examples/js folder. The script copies over the *.js files in that folder to make the Jekyll site.

What's currently missing is the skipto.js file, which is being referenced in this portion of the code , which was previously jumpto.js. As a result, the build script fails.

skipto.js was added to a location in the wai-aria-practices repo which can be overwritten (in this PR). Would it be possible to copy over skipto.js to this repo's examples/js folder to fix the build script?

cc: @jongund

@richnoah
Copy link
Contributor

@evmiguel clearance given by Task Force to move skipto.js to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants