From 238537cf597ce09a26f5dd10ad5a6c390bdbb393 Mon Sep 17 00:00:00 2001 From: michael-n-cooper Date: Fri, 14 Feb 2020 23:38:03 +0000 Subject: [PATCH] Generated by TRAVIS-CI 85085b244c91f64bb6d7eda1f46d62e1d1437d7a Combobox Examples with listbox popup: Fix Escape behavior, mouse interaction, visual design, and more (pull #1276) Fixes #785, #982, #983, #988, #1261, #1265, and #1268 with the following changes: * updated JavaScript to use single prototype * updated escape key behavior * removed unused files * fixed regression issues for escape key * updated tests for single and double escape key tests * fixed focus bug on enter and removed use of keycode property * fixed bug in opening list and improved property names for visual focus flags * fixed bug in opening list with alt key pressed * fixed bug with enter key not updating aria-expanded * fixed bugs with down arrow * added documentation and tests for ALT Down Arrow * fixed some styling bugs * Use only one SVG image to show listbox state * updated CSS for styling listbox focus * fixed scrolling issue in listbox * adjusted position of svg image button * fixed onclik bug where not selecting options when autocomplete is list or none * updated test for autocomplete, list and none * fixed bug with onclick behavior and documented option filtering as users type * updated documentation about filtering of options * Typo: character -> characters * fixed option filter bug with autocomplete=none * improved description of when listbox opens * use lowercase "the" in sentence * Minor editorial revision to alt+down in textbox keyboard table * udpated test file to check for aria-selected on option when listbox opens * fixed aria-selected tests * add tests for aria-selected to key down tests * Add aria-hidden=false and focusable=false to svg in button * Use fewer descendant combinators in selectors * Call function instead of setting a property on elements * Don't call setValue() when hitting backspace, to avoid moving the cursor to the end * Remove superfluous isPrintableCharacter() call * Remove unused variable textContent * Declare option outside for loop. Also use null instead of false * Set scrollTop once * Declare index variable in the if block * Move isPrintableCharacter to ComboboxAutocomplete.prototype * Add information about the id attribute for all combobox examples; fixes #785 Co-authored-by: Carolyn MacLeod Co-authored-by: Matt King Co-authored-by: Valerie Young Co-authored-by: Simon Pieters --- .../combobox/combobox-autocomplete-both.html | 53 +- .../combobox/combobox-autocomplete-list.html | 56 +- .../combobox/combobox-autocomplete-none.html | 55 +- ...combobox.css => combobox-autocomplete.css} | 43 +- examples/combobox/js/combobox-autocomplete.js | 555 ++++++++++++++++++ examples/combobox/js/combobox-list.js | 403 ------------- examples/combobox/js/listbox.js | 225 ------- examples/combobox/js/listboxOption.js | 42 -- index.html | 2 +- 9 files changed, 688 insertions(+), 746 deletions(-) rename examples/combobox/css/{combobox.css => combobox-autocomplete.css} (69%) create mode 100644 examples/combobox/js/combobox-autocomplete.js delete mode 100644 examples/combobox/js/combobox-list.js delete mode 100644 examples/combobox/js/listbox.js delete mode 100644 examples/combobox/js/listboxOption.js diff --git a/examples/combobox/combobox-autocomplete-both.html b/examples/combobox/combobox-autocomplete-both.html index 0a4b273c27..78a33482fe 100644 --- a/examples/combobox/combobox-autocomplete-both.html +++ b/examples/combobox/combobox-autocomplete-both.html @@ -12,10 +12,8 @@ - - - - + +