attribute error due to missing reentrancy_key_position

[cyberthirst]

Version Information

• vyper Version (output of vyper --version): 0.4.0b6+commit.e29a584c

What's your issue about?

# main.vy
import lib1

exports: lib1.bar

@external
def foo():
    pass
    
# lib1.vy
@external
@nonreentrant
def bar():
    pass

raises:

AttributeError: 'ContractFunctionT' object has no attribute 'reentrancy_key_position'. Did you mean: 'set_reentrancy_key_position'?

another variant:

#main.vy
import lib1

@external
def foo():
    lib1.bar()

#lib1.vy
@internal
@nonreentrant
def bar():
    pass

How can it be fixed?

Didn't check thoroughly but the recursion to imported modules in the allocation phase is guided by:

vyper/vyper/semantics/analysis/data_positions.py

Line 275 in 20432c5

if isinstance(node, vy_ast.InitializesDecl):

which is missing in this instance

[cyberthirst]

note from @trocher:
When a module is never initialized, it should only be allowed to call
functions that are stateless in the sense that they do not access
storage or immutables. However, the analysis does not account for
non-reentrant decorators. If a non-initialized module's non-reentrant
function is called, the compiler will crash during code generation after
successfully passing semantic analysis.