Commit 569f8ad Ayzat Murtazin
committed
1 parent 4e46ee6 commit 569f8ad Copy full SHA for 569f8ad
File tree 2 files changed +7
-12
lines changed
main/java/ru/yandex/practicum/filmorate/dao/impl
test/java/ru/yandex/practicum/filmorate/storage
2 files changed +7
-12
lines changed Original file line number Diff line number Diff line change 12
12
import ru .yandex .practicum .filmorate .dao .FilmStorage ;
13
13
import ru .yandex .practicum .filmorate .dto .FilmSearchDto ;
14
14
import ru .yandex .practicum .filmorate .exception .NotFoundException ;
15
- import ru .yandex .practicum .filmorate .model .Director ;
16
- import ru .yandex .practicum .filmorate .model .Film ;
17
- import ru .yandex .practicum .filmorate .model .Genre ;
18
- import ru .yandex .practicum .filmorate .model .Mpa ;
19
- import ru .yandex .practicum .filmorate .model .SearchBy ;
15
+ import ru .yandex .practicum .filmorate .model .*;
20
16
21
17
import java .sql .Date ;
22
18
import java .sql .PreparedStatement ;
@@ -200,13 +196,11 @@ public Collection<Film> searchFilms(FilmSearchDto search) {
200
196
.append (search .getQuery ())
201
197
.append ("%' " );
202
198
}
203
- sql .append ("GROUP BY f.id, m.rating_name, d.DIRECTOR_NAME ORDER BY COUNT(fl.USER_ID) DESC" );
204
-
199
+ sql .append ("GROUP BY f.id ORDER BY COUNT(fl.USER_ID) DESC" );
205
200
Collection <Film > films = jdbcTemplate .query (sql .toString (), this ::mapToFilm );
206
- LinkedHashSet <Film > unique = new LinkedHashSet <>(films );
207
- setDirectorsForFilms (unique );
208
- setGenresForFilms (unique );
209
- return unique ;
201
+ setDirectorsForFilms (films );
202
+ setGenresForFilms (films );
203
+ return films ;
210
204
}
211
205
212
206
private List <Film > setGenresForFilms (Collection <Film > films ) {
Original file line number Diff line number Diff line change @@ -375,6 +375,7 @@ void testSearchFilmByDirector() {
375
375
assertThat (films )
376
376
.isNotNull ()
377
377
.isNotEmpty ()
378
+ .usingRecursiveComparison ()
378
379
.isEqualTo (List .of (newFilm ));
379
380
}
380
381
@@ -391,7 +392,7 @@ void testSearchFilmByPartialTitle() {
391
392
assertThat (films )
392
393
.isNotNull ()
393
394
.isNotEmpty ()
394
- .isEqualTo (List .of (updatedFilm ));
395
+ .isEqualTo (List .of (newFilm ));
395
396
}
396
397
397
398
@ Test
You can’t perform that action at this time.
0 commit comments