Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue ui git initialization #5280

Closed
kerolloz opened this issue Mar 16, 2020 · 5 comments
Closed

Vue ui git initialization #5280

kerolloz opened this issue Mar 16, 2020 · 5 comments

Comments

@kerolloz
Copy link

image

It was not clear to me that initializing the folder as a git repo will lead to committing all the files with 'init' as a commit message. I thought if I didn't write an initial commit message, that means it will just initialize it as a git repo. I think committing all the files shouldn't be a side effect of initializing the repo. I suggest making that more clear by stating that 'init' is the default commit message if you don't choose one.

Thank you for the great Vue UI. ✨

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 28, 2020

Hi @kerolloz! Adding the init commit is also exactly the default behavior when initializing a new project with vue create instead of vue ui. I think it makes sense to have the same behavior using both options. What do you think?

In any case, maybe changing the input placeholder from A to B or C, following the language used in the rest of that form, could make this more clear:

A. Initial commit message (optional)
B. Overwrite initial commit message (optional)
C. Type an initial commit message (optional)

/cc @Akryum because #1541.

@kerolloz
Copy link
Author

Hi @gtsiolis
I totally agree with you. Yeah same behavior for both options.
I like option B or anything similar. The most important thing is that It's clear that there is an initial commit message not just git repo initialization.

@gtsiolis
Copy link
Contributor

Sounds good @kerolloz! I've added a simpler version of B in https://github.com/vuejs/vue-cli/pull/5329/files#diff-08505d20b45fb530abc924ab6c35b9a6R302. Let's see what others think. 🏀

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 31, 2020

Since #5329 has been merged, maybe it's ok to close this unless I'm missing a development flow that needs this to be open until it reaches master. WDYT? /cc @kerolloz @sodatea

@haoqunjiang
Copy link
Member

haoqunjiang commented Mar 31, 2020

Yeah I forgot to close it in the commit message.
Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants