Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter key in IME mode would trigger search in search bar #4343

Closed
4 tasks done
Jorrrmungandr opened this issue Nov 7, 2024 · 0 comments
Closed
4 tasks done

Enter key in IME mode would trigger search in search bar #4343

Jorrrmungandr opened this issue Nov 7, 2024 · 0 comments
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@Jorrrmungandr
Copy link

Jorrrmungandr commented Nov 7, 2024

Describe the bug

When composing in Chinese IME (maybe also in other East Asian language IME), pressing enter key should finish composing rather than trigger a search. This problem has been fixed in docsearch 3.7.0 (algolia/autocomplete#1238), but the version in vitepress is 3.6.2. I've locally updated the dependencies and it works as expected. I wonder if I could submit a PR to address this issue?

Reproduction

vitepress-bug.mov

Expected behavior

When composing in Chinese IME (maybe also in other East Asian language IME), pressing enter key should finish composing rather than trigger a search.

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 125.72 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.18.0 - ~/.nvm/versions/node/v20.18.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.18.0/bin/npm
    pnpm: 9.12.3 - ~/.nvm/versions/node/v20.18.0/bin/pnpm
  Browsers:
    Chrome: 123.0.6312.124
    Safari: 16.5.1

Additional context

No response

Validations

@Jorrrmungandr Jorrrmungandr added the bug: pending triage Maybe a bug, waiting for confirmation label Nov 7, 2024
@brc-dd brc-dd closed this as completed in 36e0c1a Nov 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

1 participant