Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter ignores files with dash instead of underscore #21

Open
wdsrocha opened this issue Jan 19, 2021 · 1 comment
Open

Linter ignores files with dash instead of underscore #21

wdsrocha opened this issue Jan 19, 2021 · 1 comment

Comments

@wdsrocha
Copy link
Contributor

wdsrocha commented Jan 19, 2021

Expected Behavior

It should lint files that use a dash to split language code from country code, like en-US or pt-PT.

UPDATE: just realized this only happens for deletion of lines, but linter works fine if there is a misspell of some key...

Current Behavior

Only works when an underscore is used, like en_US.

Steps to Reproduce (for bugs)

  1. Clone https://github.com/vtex-apps/order-placed
  2. Copy messages/en.json to a new file messages/en-US.json
  3. Delete few lines (except the first and the last one...)
  4. Run the script. It won't raise errors.

Context

I was trying to run the script for a PR that added pt-PT.json here: vtex-apps/order-placed#137

Your Environment

Version: v2.5.0

@wdsrocha
Copy link
Contributor Author

@lucasecdb any clue on how to solve this? I suppose there is a regex somewhere that looks for underscore and changing that would fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant