WIP rebasing | feat(store-ui): Spinner atom #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 802c06e 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6143806381332a00075e9f79 😎 Browse the preview: https://deploy-preview-946--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 802c06e:
|
There was a problem hiding this comment.
Nice job, @Gmantiqueira!
Can you left a store PR for us to see the performance impact?
Also, we should discuss only have the spinner and not the button with loading.
abb91f5 to
8dae0f3
Compare
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
Create List component as an Atom.
* Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement
e495b5e to
29246d9
Compare
added 2 commits
September 15, 2021 15:13
854fe99 to
802c06e
Compare
|
created another PR #961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is related to Loading Button component/task. IMO It doesn't make sense creating a molecule only for the Loading Button, since the loading is handled on the Button atom children. So, we just need a Spinner component to alternate between the Button text and a loading indicator.
How it works?
How to test it?
References